Skip to content

[v3] Database#on is not supporting cancel callbacks #91

Open
@pedro-ribeiro

Description

@pedro-ribeiro
Contributor

Database#on is not supporting setting cancel callbacks. This makes it impossible to deal with Permission Denied errors.

Currently, on error the library will simply log the error message. (https://github.com/fullstackreact/react-native-firestack/blob/master/lib/modules/database.js#L401)

See Firebase documentation.

Activity

auser

auser commented on Oct 27, 2016

@auser
Contributor

Mmm good catch. I must have left this on the TODO. Think we should just throw a JS event back on errors?

pedro-ribeiro

pedro-ribeiro commented on Oct 27, 2016

@pedro-ribeiro
ContributorAuthor

In my opinion, it should mimic as much as possible the firebase js sdk.

self-assigned this
on Nov 9, 2016
added this to the v3 milestone on Nov 23, 2016
changed the title [-]Database#on is not supporting cancel callbacks[/-] [+][v3] Database#on is not supporting cancel callbacks[/+] on Nov 23, 2016
janvogt

janvogt commented on Nov 28, 2016

@janvogt
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @auser@pedro-ribeiro@janvogt@Salakar

      Issue actions

        [v3] Database#on is not supporting cancel callbacks · Issue #91 · fullstackreact/react-native-firestack