Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

We should enable integration tests in CI #52

Open
victornoel opened this issue Jun 25, 2019 · 16 comments
Open

We should enable integration tests in CI #52

victornoel opened this issue Jun 25, 2019 · 16 comments
Assignees
Labels
bug Something isn't working scope

Comments

@victornoel
Copy link
Contributor

Apparently running maven with -Pitcase fails the build because of some infrastructure problem.

See for example https://circleci.com/gh/g4s8/ghman/118 where it happens.

This should be fixed.

@0crat
Copy link

0crat commented Jun 25, 2019

@g4s8/z please, pay attention to this issue

@g4s8 g4s8 added the bug Something isn't working label Jun 26, 2019
@0crat 0crat added the scope label Jun 26, 2019
@0crat
Copy link

0crat commented Jun 26, 2019

Job #52 is now in scope, role is DEV

@0crat
Copy link

0crat commented Jun 26, 2019

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

@0crat
Copy link

0crat commented Jul 9, 2019

The job #52 assigned to @scristalli/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@scristalli
Copy link
Contributor

@victornoel @g4s8 observation: the problem is not exclusive of CircleCI, it happens when building locally too. Exceptions causing the problem:

Caused by: java.io.IOException: Server returned HTTP response code: 403 for URL: http://get.enterprisedb.com/postgresql/postgresql-11.1-1-linux-x64-binaries.tar.gz

It seems that EnterpriseDB doesn't support these unauthenticated APIs for donwloading binaries anymore, I see no documentation and I get "access denied" on all of them.

The component we are using (postgresql-embedded) should update its internal working to fix this. Its README though says that the project is not actively maintained anymore, and that the official recommended alternative is Testcontainers. For this reason, I suggest we switch to Testcontainers.

I tried doing this modification, which the super powers of OOP should make pretty smooth. Too bad, I encountered a problem: Testcontainers' containers require username/password-based authentication, and the com.jcabi.jdbc.JdbcSession class we are using doesn't allow to specify them in a connection.
I opened jcabi/jcabi-jdbc#73 to address this.

What do you think? Does it seem reasonable to make this transition?

@victornoel
Copy link
Contributor Author

@scristalli isn't the login/password specified at the datasource level?

@0crat
Copy link

0crat commented Jul 14, 2019

@scristalli/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@scristalli
Copy link
Contributor

@0crat wait for jcabi/jcabi-jdbc#73.

@0crat 0crat added the waiting label Jul 15, 2019
@0crat
Copy link

0crat commented Jul 15, 2019

@0crat wait for jcabi/jcabi-jdbc#73. (here)

@scristalli The impediment for #52 was registered successfully by @scristalli/z

@victornoel
Copy link
Contributor Author

@scristalli as I told you above, this won't be solved by jcabi-jdbc since the login/password is given to the DataSource, itself given to jcabi-jdbc. jcabi-jdbc does not care how the DataSource is created.

@scristalli
Copy link
Contributor

@victornoel thanks for your comment, I was able to set username and password in the JDBC URL in my PR. I'm still a bit confused, everywhere I look in standard documentation (example) I see these parameters set when calling DataSource.getConnection(String username, String password), while I don't see any method to specify them in the DataSource object, so I think that by Java's original semantics they are not intended to be a property of the datasource, but rather one of the single connection.

@scristalli
Copy link
Contributor

@0crat resign

@0crat
Copy link

0crat commented Jul 16, 2019

@0crat resign (here)

@scristalli The user @scristalli/z resigned from #52, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link

0crat commented Jul 16, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @scristalli/z

@g4s8 g4s8 self-assigned this Jul 16, 2019
g4s8 added a commit that referenced this issue Jul 16, 2019
@0crat 0crat removed the waiting label Jul 16, 2019
@0crat
Copy link

0crat commented Jul 16, 2019

The job #52 assigned to @g4s8/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link

0crat commented Jul 16, 2019

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @g4s8/z

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working scope
Projects
None yet
Development

No branches or pull requests

4 participants