Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA test that verify tags in the module manifest #446

Open
johlju opened this issue Oct 28, 2023 · 0 comments
Open

QA test that verify tags in the module manifest #446

johlju opened this issue Oct 28, 2023 · 0 comments
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Collaborator

johlju commented Oct 28, 2023

Problem description

It is easy to not know or forget that tags in the module manifest are not allowed, this would fail to deploy the module. It is also easily missed in the review process.

Verbose logs

n/a

How to reproduce

Add a tag containing a space in the module manifest and try to deploy the module.

Expected behavior

To fail the build when module manifest is incorrect and will fail deploy.

Current behavior

There are no tests that can help catch this

Suggested solution

Add a QA test that help validate the module manifest. At least the tags.

Operating system the target node is running

n/a

PowerShell version and build the target node is running

n/a

Module version used

n/a
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only. labels Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only.
Projects
None yet
Development

No branches or pull requests

1 participant