update ggplot scatterplot tool #6715
Open
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgruening ready for review |
SaimMomin12
approved these changes
Feb 3, 2025
|
@hechth can you please test in planemo what happens when you provide a file without a header? How does the UI react? |
|
Well it just will always think there is a header ... so it treats the first line as a header. |
|
@bgruening I added a select to choose whether there is a header or not |
There was a problem hiding this comment.
In hindsight I wish I would not have implemented galaxyproject/galaxy@2395e65.
An.extra tool that just adds metadata to a tabular file would have been better. Maybe such a tool would even be possible without duplicating the dataset.
Then you could just rely on the metadata here (and no conditional would be needed) and the user could use the additional tool to set the metadata of needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
Closes #6692