Problem
nmea_validate_checksum() in nmea_parser.hpp:80-82 returns true when * (checksum delimiter) is not found. This means NMEA sentences without checksums are accepted as valid, which is risky for safety-critical GPS data.
Location
firmware/main/nmea_parser.hpp:80-82
Severity
HIGH - Invalid/corrupted GPS data could be accepted
Suggested Fix
Return false when checksum is absent, or log a warning and require checksum to be present.
Problem
nmea_validate_checksum()innmea_parser.hpp:80-82returnstruewhen*(checksum delimiter) is not found. This means NMEA sentences without checksums are accepted as valid, which is risky for safety-critical GPS data.Location
firmware/main/nmea_parser.hpp:80-82Severity
HIGH - Invalid/corrupted GPS data could be accepted
Suggested Fix
Return
falsewhen checksum is absent, or log a warning and require checksum to be present.