bug: wait_busy() can loop forever on hardware fault

[gdellis]

Problem

wait_busy() in sx1262.cpp:484-494 tracks timeout but never exits the loop when timeout is reached. If is_busy() always returns true (hardware fault, busy pin stuck high), the loop runs forever.

Location

• firmware/main/lora/sx1262.cpp:484-494

Severity

HIGH - System hang on LoRa hardware fault

Suggested Fix

Add explicit timeout check in the while loop condition, or return error on timeout.

[gdellis]

After code review, wait_busy() at sx1262.cpp:485-496 DOES return ESP_ERR_TIMEOUT when timeout is reached. The while loop exits when elapsed >= timeout_ms * 1000, and the if block correctly returns ESP_ERR_TIMEOUT. This was a false positive - the code is correct.