Skip to content

bug: BLE struct padding causes serialization corruption #45

@gdellis

Description

@gdellis

Problem

BleLocationData and BleAlertData structs in ble.hpp have alignment padding. When memcpy is used to copy these structs, padding bytes are included, sending garbage data over BLE.

For example, BleLocationData has int32_t x 4 + uint8_t = 17 bytes, but struct padding makes it 20 or 24 bytes.

Location

  • firmware/main/ble.hpp:23-38

Severity

HIGH - Garbage data sent over BLE, location/alert data corrupted

Suggested Fix

Add #pragma pack(1) before struct definitions, or explicitly add uint8_t reserved[X] to make serialization deterministic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions