fix: add static_assert for BLE structs and [[nodiscard]] to methods#65
Closed
gdellis wants to merge 1 commit into
Closed
fix: add static_assert for BLE structs and [[nodiscard]] to methods#65gdellis wants to merge 1 commit into
gdellis wants to merge 1 commit into
Conversation
Owner
Author
|
The changes this PR intended to add (static_assert for BLE structs and [[nodiscard]] on esp_err_t methods) were already merged via PR #52. The branch has been rebased onto current main and no additional changes are needed. Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address issues #61 and #62:
static_assertto verify BLE struct sizes at compile time[[nodiscard]]to allesp_err_treturning methods to catch ignored errors at compile timestate_machine.cppto useESP_ERROR_CHECKonble_.send_alert()call (required after adding[[nodiscard]])Changes
firmware/main/ble.hpp:
#pragma pack(push, 1)andstatic_assertfor BleLocationData (17 bytes) and BleAlertData (18 bytes)[[nodiscard]]to:init(),start(),stop(),update_location(),send_alert(),set_device_name()firmware/main/state_machine.cpp:
ESP_ERROR_CHECKonble_.send_alert()in geofence breach handlingTesting
Closes #61, #62