Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dimRed on CRAN #57

Open
topepo opened this issue Jan 12, 2025 · 7 comments
Open

dimRed on CRAN #57

topepo opened this issue Jan 12, 2025 · 7 comments

Comments

@topepo
Copy link
Contributor

topepo commented Jan 12, 2025

We saw this on 2015-01-12:

Package ‘dimRed’ was removed from the CRAN repository.
Formerly available versions can be obtained from the archive.
Archived on 2025-01-10 as check problems were not corrected despite reminders.
A summary of the most recent check results can be obtained from the check results archive.
Please use the canonical form https://CRAN.R-project.org/package=dimRed to link to this page.

Is there a plan to put it back on CRAN? Is there anything that we can help with?

@gdkrmr
Copy link
Owner

gdkrmr commented Jan 16, 2025

The issue is the following:

  • There was a dependency (loe) that was removed from CRAN, this was an easy fix.
  • The autoencoder code stopped working because the keras api changed the autoencoder has to be reimplemented. I did start it here: https://github.com/gdkrmr/dimRed/tree/cranfix

At the moment I am lacking the energy and time to sit down and redo the autoencoder properly. Is there a proper autoencoder in R now that we can wrap? I did the autoencoder myself back when I created the package mostly because there was no package that provided a good autoencoder implementation.

@topepo
Copy link
Contributor Author

topepo commented Jan 16, 2025

Outside of h2o, I don't see anything ready-made for general problems.

I've been using R's torch implementation, and you could translate it over (when you have time).

I'm pinging our keras people to see if one of them can help out. If they don't get back to me in a day or so, I'd probably remove the function and go with what you have.

@gdkrmr
Copy link
Owner

gdkrmr commented Jan 26, 2025

resubmitted, let's see. some of the tests/examples are still failing but I think this is due to how the environment is set up.

@gdkrmr
Copy link
Owner

gdkrmr commented Jan 27, 2025

Tests fail on M1 Macs. It seems to be a numerical issue that I cannot debug. Any ideas?

https://www.stats.ox.ac.uk/pub/bdr/M1mac/dimRed.out

@topepo
Copy link
Contributor Author

topepo commented Jan 27, 2025

We'll take a look. We have seen some differences of results for this chip (especially early on).

@topepo
Copy link
Contributor Author

topepo commented Jan 28, 2025

I cannot reproduce his issue. When testing test_NNMF.R I get

==> Testing R file using 'testthat'

ℹ Loading dimRed
Loading required package: DRR
Loading required package: kernlab
Loading required package: CVST
Loading required package: Matrix
Creating a new generic function for ‘as.data.frame’ in package ‘dimRed’
Creating a new generic function for ‘embed’ in package ‘dimRed’
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 12 ]
Test complete

I would probably skip_on_cran()

@gdkrmr
Copy link
Owner

gdkrmr commented Jan 29, 2025

Thanks for testing. We don't have an free Macbook at work, so I have a colleague test it and then just do skip_on_cran() if there are no big revelations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants