Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(idea/frontend): migrate voucher indexer #1667

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(idea/frontend): migrate voucher indexer #1667

wants to merge 3 commits into from

Conversation

Zewasik
Copy link
Member

@Zewasik Zewasik commented Nov 10, 2024

Resolves #1664 .

  • change useVouchers hook to handle new requests

@osipov-mit

@nikitayutanov
Copy link
Member

To remove:

  • VITE_MAINNET_VOUCHERS_API_URL and VITE_TESTNET_VOUCHERS_API_URL variables in .env.example
  • VOUCHERS_API_URL const in a shared/config/consts
  • previous getVouchers implementation in features/voucher/utils alongside with VouchersResponse type I guess

@nikitayutanov
Copy link
Member

Good to go, thanks!

@nikitayutanov nikitayutanov changed the title refactor(idea/frontend) change voucher request refactor(idea/frontend): migrate voucher indexer Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitayutanov nikitayutanov nikitayutanov approved these changes

@osipov-mit osipov-mit Awaiting requested review from osipov-mit

@vraja-nayaka vraja-nayaka Awaiting requested review from vraja-nayaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(idea/frontend): voucher requests
2 participants
@Zewasik @nikitayutanov