The method createNewFile converts all the inputstream to memory. This could cause out of memory errors.

Now the process use a buffer to avoid this.
Issue: 205339

Author: iroqueta

gxcloudstorage-awss3/src/main/java/com/genexus/db/driver/ExternalProviderS3.java

@@ -17,7 +17,6 @@
 
 import com.amazonaws.services.s3.AmazonS3;
 import com.amazonaws.services.s3.AmazonS3Client;
-import com.amazonaws.util.IOUtils;
 
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
@@ -209,26 +208,34 @@ else if (acl == ResourceAccessControlList.PublicReadWrite) {
         return accessControl;
     }
 
-    public String upload(String externalFileName, InputStream input, ResourceAccessControlList acl) {
-        byte[] bytes;
-        try {
-            bytes = IOUtils.toByteArray(input);
-            ObjectMetadata metadata = new ObjectMetadata();
-            metadata.setContentLength(bytes.length);
-            if (externalFileName.endsWith(".tmp")) {
-                metadata.setContentType("image/jpeg");
-            }
-            String upload = "";
-            try (ByteArrayInputStream byteArrayInputStream = new ByteArrayInputStream(bytes)) {
-				client.putObject(new PutObjectRequest(bucket, externalFileName, byteArrayInputStream, metadata).withCannedAcl(internalToAWSACL(acl)));
-				upload = getResourceUrl(externalFileName, acl, defaultExpirationMinutes);
+	public String upload(String externalFileName, InputStream input, ResourceAccessControlList acl) {
+		ExternalProviderHelper.InputStreamWithLength streamInfo = null;
+		try {
+			streamInfo = ExternalProviderHelper.getInputStreamContentLength(input);
+
+			ObjectMetadata metadata = new ObjectMetadata();
+			metadata.setContentLength(streamInfo.contentLength);
+
+			if (externalFileName.endsWith(".tmp")) {
+				metadata.setContentType("image/jpeg");
 			}
+			String upload = "";
+			client.putObject(new PutObjectRequest(bucket, externalFileName, streamInfo.inputStream, metadata).withCannedAcl(internalToAWSACL(acl)));
+			upload = getResourceUrl(externalFileName, acl, defaultExpirationMinutes);
 			return upload;
-        } catch (IOException ex) {
-            logger.error("Error while uploading file to the external provider.", ex);
-            return "";
-        }
-    }
+		} catch (IOException ex) {
+			logger.error("Error while uploading file to the external provider.", ex);
+			return "";
+		} finally {
+			if (streamInfo != null && streamInfo.tempFile != null && streamInfo.tempFile.exists()) {
+				try {
+					streamInfo.tempFile.delete();
+				} catch (Exception e) {
+					logger.warn("Could not delete temporary file: " + streamInfo.tempFile.getAbsolutePath(), e);
+				}
+			}
+		}
+	}
 
     public String get(String externalFileName, ResourceAccessControlList acl, int expirationMinutes) {
         client.getObjectMetadata(bucket, externalFileName);

gxcloudstorage-common/src/main/java/com/genexus/db/driver/ExternalProviderHelper.java

@@ -3,6 +3,8 @@
 import com.genexus.util.Encryption;
 import com.genexus.util.GXService;
 
+import java.io.*;
+
 public class ExternalProviderHelper {
 
 	public static String getServicePropertyValue(GXService s, String propName, boolean isSecure){
@@ -23,4 +25,30 @@ public static String getEnvironmentVariable(String name, boolean required) throw
 		}
 		return value;
 	}
+
+	public static InputStreamWithLength getInputStreamContentLength(InputStream input) throws IOException {
+		File tempFile = File.createTempFile("upload-", ".tmp");
+		try (OutputStream out = new FileOutputStream(tempFile)) {
+			byte[] buffer = new byte[8192];
+			int bytesRead;
+			while ((bytesRead = input.read(buffer)) != -1) {
+				out.write(buffer, 0, bytesRead);
+			}
+		}
+		long size = tempFile.length();
+		InputStream newInput = new FileInputStream(tempFile);
+		return new InputStreamWithLength(newInput, size, tempFile);
+	}
+
+	public static class InputStreamWithLength {
+		public final InputStream inputStream;
+		public final long contentLength;
+		public final File tempFile; // nullable
+
+		public InputStreamWithLength(InputStream inputStream, long contentLength, File tempFile) {
+			this.inputStream = inputStream;
+			this.contentLength = contentLength;
+			this.tempFile = tempFile;
+		}
+	}
 }