Search parcels by lot : numbered tabs

[MaelREBOUX]

Adding several tabs by selection => selection 1 | selection 2
Adding several tabs by lot => lot | lot

Possible to number the second kindsof tabs ?

[tdipisa]

@MaelREBOUX I will ask developers for a check. I think it is an easy fix to do.

[offtherailz]

Actually the titles for result tabs from various search types are defined by this function

mapstore2-cadastrapp/js/extension/epics/search.js

Lines 38 to 58 in 2273380

	function getTitle(searchType, rawParams) {
	switch (searchType) {
	case SEARCH_TYPES.REFERENCE:
	return rawParams?.commune?.label;
	case SEARCH_TYPES.ADDRESS:
	return rawParams?.commune?.label;
	case SEARCH_TYPES.LOT:
	return "Lot";
	case SEARCH_TYPES.ID:
	return "Id(s)";
	case SEARCH_TYPES.OWNER_ID:
	return rawParams?.commune?.label;
	case SEARCH_TYPES.COMPTE_COMMUNAL:
	return rawParams?.comptecommunal;
	case SEARCH_TYPES.OWNER_LOT:
	return "By file";
	default:
	return null;
	}
	}

The current numbering system is implemented to provide a title to a tab that has not a specific title.
If "no title" is provided the title is assigned as an incremental `Selection where number is the index of the tab.

mapstore2-cadastrapp/js/extension/components/PlotSelection.jsx

Lines 91 to 93 in 2273380

	const getPlotTitle = (plot, index) => {
	return plot?.title ?? ("Selection " + (index + 1).toString());
	};

So you will have

"Selection 1", "Lot", "Selection 3"...

So applying strictly this logic is not optimal, generating titles like:
"Selection 1", "Lot 2", "Selection 3", "Lot 4", ...

I think there is a mismatch of meaning between "Selection" as a "generic selection" of parcelles, or "Selection" as "selected on map". The application now want to express the first meaning.

I think there are 2 ways to do this.

1. Use "Selection" for all the selections on map, as in the original application.
2. Something more complicated like:

"Selection 1", "Lot 1", Selection 2, "Lot 3", Rennes (....) 1", "Rennes (....) // <-- there are also the other titles.

To do this we need to remove the current logic and add counter for each type when generating the titles, and removing the default case with no-title.

@tdipisa what's your opinion ?

[MaelREBOUX]

Hello @offtherailz my opinion : I agree with your proposition. The important is to not have identical tab title

[MaelREBOUX]

warning : interaction with discussion in #115 (comment)