Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit sort implementation in interior_point in light of changes in Rust 1.81 #1213

Closed
urschrei opened this issue Sep 7, 2024 · 0 comments · Fixed by #1218
Closed

Revisit sort implementation in interior_point in light of changes in Rust 1.81 #1213

urschrei opened this issue Sep 7, 2024 · 0 comments · Fixed by #1218
Labels
bug refactoring

Comments

@urschrei
Copy link
Member

urschrei commented Sep 7, 2024

In light of the sort changes in Rust 1.81 (discussed here) I note that one of our sort_by implementations is vulnerable to panic: https://github.com/georust/geo/blob/main/geo/src/algorithm/interior_point.rs#L213.

We should fix this ASAP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace partial_cmp with total_cmp in sorting grevgeny/geo
1 participant
@urschrei