Fix #10910 search bar overlap gfi panel #10913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdipisa
added
the
BackportNeeded
dsuren1
requested changes
Mar 11, 2025
| (currentContext, contextPlugins = {}) => !currentContext || | ||
| findIndex(get(contextPlugins, 'desktop', []), plugin => plugin.name === pluginName) > -1 | ||
| ); | ||
| export const isPluginInContext = pluginName => state => { |
There was a problem hiding this comment.
is the memoization of createSelector causing issue?
| @@ -261,7 +261,7 @@ export const zoomToVisibleAreaEpic = (action$, store) => | |||
| const state = store.getState(); | |||
| const hideIdentifyPopupIfNoResults = hideEmptyPopupSelector(state); | |||
| const hoverIdentifyActive = isMouseMoveIdentifyActiveSelector(state); | |||
| const noResultFeatures = loadFeatInfoAction.type === LOAD_FEATURE_INFO && loadFeatInfoAction?.data?.includes("no features were found"); | |||
| const noResultFeatures = loadFeatInfoAction.type === LOAD_FEATURE_INFO && loadFeatInfoAction?.data?.includes?.("no features were found"); | |||
There was a problem hiding this comment.
Suggested change
| const noResultFeatures = loadFeatInfoAction.type === LOAD_FEATURE_INFO && loadFeatInfoAction?.data?.includes?.("no features were found"); | |
| const noResultFeatures = loadFeatInfoAction.type === LOAD_FEATURE_INFO && typeof loadFeatInfoAction?.data === "string" && loadFeatInfoAction?.data?.includes("no features were found"); |
For readability purpose, can we do this instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the value of isIdentifyInContext was incorrectly set to false and no longer being updated this was making the selector isMapinfoOpen here in the mapLayout epic to be false and therefore ignored for moving away the search bar with correct style properties
I also fixed another error in console
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10910
What is the new behavior?
it works fine, also tested by closing gfi and opening catalog
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information