Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10912 by making dialog opening to the left of the image button #10920

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #10912 by making dialog opening to the left of the image button #10920

wants to merge 2 commits into from

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Mar 10, 2025

Description

This is the new behaviour
image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #10912

What is the new behavior?

Now opens to the left

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch MapStore Homepage labels Mar 10, 2025
@MV88 MV88 added this to the 2025.01.00 milestone Mar 10, 2025
@MV88 MV88 self-assigned this Mar 10, 2025
@tdipisa tdipisa requested a review from dsuren1 March 10, 2025 15:02
dsuren1
dsuren1 requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MV88
This update creates issue in dashboard widget
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuren1 dsuren1 dsuren1 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@MV88 MV88

Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug MapStore Homepage
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging this pull request may close these issues.

Image upload popup is not fully visible
2 participants
@MV88 @dsuren1