Measurement in Cesium map issue

[ElenaGallo]

Description

It is not possible to measure on 3D map. Error on console:

Uncaught TypeError: Cannot read properties of null (reading 'removeAll')
at T._updateDynamicCoordinates (cesiumDrawGeometrySupport.7c28dffed39bdf8a.chunk.js:1:8137)
at T._drawPrimitives (cesiumDrawGeometrySupport.7c28dffed39bdf8a.chunk.js:1:7905)
at T._handleMouseMove (cesiumDrawGeometrySupport.7c28dffed39bdf8a.chunk.js:1:4873)
at cesiumDrawGeometrySupport.7c28dffed39bdf8a.chunk.js:1:2754
at v (mapstore2.js?7c28dffed39bdf8a:2:2771744)
at E (mapstore2.js?7c28dffed39bdf8a:2:2772167)
at x (6714.7c28dffed39bdf8a.chunk.js:2:323577)
at W (6714.7c28dffed39bdf8a.chunk.js:2:327981)
at HTMLCanvasElement.o (6714.7c28dffed39bdf8a.chunk.js:2:321898)

How to reproduce

• Open a 3D map

• Click on Measure tool

• Draw a measurement on map

• Not browser related

Browser info

(use this site: https://www.whatsmybrowser.org/ for non expert users)

Browser Affected	Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

[MV88]

This issue looks to be cause from this commit
798ec3d

I'm checking why

@dsuren1 perhaps, do you remember why it was added the onDrawEnd in the useEffect because this is causing the issue

[dsuren1]

@MV88

MapStore2/web/client/plugins/Annotations/containers/AnnotationsMapInteractionsSupport.jsx

Lines 58 to 61 in a5a26ed

	onDrawEnd={({ feature: newFeature }) => {
	onChange({
	...feature,
	properties: {

Upon finishing the draw, feature value here is not latest due to stale closure, hence the onDrawEnd was added as a dependency

[MV88]

@MV88

MapStore2/web/client/plugins/Annotations/containers/AnnotationsMapInteractionsSupport.jsx

Lines 58 to 61 in a5a26ed

onDrawEnd={({ feature: newFeature }) => {
onChange({
...feature,
properties: {
Upon finishing the draw, feature value here is not latest due to stale closure, hence the onDrawEnd was added as a dependency

but this is causing the issue described here Can we have a quick sync to explore alternatives?

Also maybe having it defined as arrow function could make the function being created every time and not once. i guess it might be good to check if using useCallback might change. But I'll try that after the sync eventually