Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ea0688cc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace the nested Prompt · Default disclosure with a compact edit button beside Test, show Custom prompt in the row description only when customized, and auto-size the inline editor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace full-prompt overrides (threadNamingPrompt, commitMessagePrompt) with threadTitleInstructions and commitMessageInstructions that are appended to bb's built-in rules, matching Zed, VS Code Copilot, and JetBrains. A short instruction like "Write titles in French." no longer drops length, casing, and format rules. The editor starts empty with an example placeholder; clearing and saving restores the built-in rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Render loading and loaded rows through the same instructions wrapper so the service dropdown is not remounted when the view arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Show an always-visible instructions field under Thread titles and Commit messages that autosaves on blur, matching the Custom instructions plugin settings page, instead of a pencil-toggled editor with Save and Cancel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Show + Add instructions until instructions exist; it expands and focuses the field, which collapses again when left empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hread-naming-prompt-settings-thr_qy2yfwjgn2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep main's loading and loaded row branches, each wrapped in a row div so the dropdown keeps its identity, and revert formatting-only hunks in the migrate test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brsbl
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…losures Move the instructions docs under the existing AI services sections with a per-task settings table, and state in bb cloud's data disclosures that any instructions added for a task are sent with that task. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each instructions field now omits the other field from its general settings update, relying on the server's existing preservation of omitted fields, so saving both fields before the config refetch cannot undo the first save. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hread-naming-prompt-settings-thr_qy2yfwjgn2
Commit message instructions are removed until someone asks for them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brsbl
changed the title
Custom instructions such as type prefixes or other languages make titles longer, and the 48-column cut chopped them mid-phrase. The sidebar already truncates long titles with an ellipsis, so the cap is only a runaway guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Titles in other languages or with a type prefix produced branch names like a-adir-gr-fico or feature-...-the-pro. Strip accents to base letters and cut long slugs at a word boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Thread titles used a fixed prompt, so users could not set the language, length, tone, or naming conventions bb uses for them.
What changed
threadTitleInstructions(1–2,000 characters, ornull) works throughbb settings generaland the SDK; older clients that omit it keep the saved value.How you verified
3fd9f27800.The prefix and Spanish columns were rerun after raising the cap; with the 48-column cut, 3 of those 13 titles had been chopped mid-phrase ("…chart to the", "…visualizador del"). The model follows instructions most of the time but not always: with the 5-word set, the burndown prompt came back in sentence case 2 of 4 times, and the Chinese prompt stays in Chinese under "Write titles in Spanish."
Not tested: bb cloud. Every run above used the Codex title service. Dev builds route bb cloud to the local cloud stack, which needs an
OPENROUTER_API_KEYto reach bb cloud's title model (inception/mercury-2.5, falling back togoogle/gemini-2.5-flash-lite), and none was available. It should be rerun with bb cloud before merging, because bb cloud is the first choice under Automatic for signed-in users.Screenshots
Before: merge base
76a1ebcaf5(unchanged on the current base). After:f3bd55fe45. Same isolated data, route, light theme, and 2× density.Title instructions saved, after a hard reload (after only):
P2 follow-ups
BB-Thread-ID: thr_qy2yfwjgn2
🤖 Generated with Claude Code