Skip to content

Keep model reasoning options on one row - #5722

Open
brsbl wants to merge 6 commits into
mainfrom
bb/menu-no-wrap-thr_jyt4i4y7p8
Open

brsbl wants to merge 6 commits into
mainfrom
bb/menu-no-wrap-thr_jyt4i4y7p8

Conversation

@brsbl

@brsbl brsbl commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Reasoning options switched to a two-row grid based on label length, making the model picker wrap. Restoring the original single row also exposed clipping on narrow phones.

What changed

  • Restore one compact reasoning row with the original menu sizing.
  • Below 360px, show Med and XHigh while preserving full accessible names.

How you verified

  • Full remote CI passed on 0524344c3. Run.
  • Chrome for Testing 155.0.8059.39: desktop, 390px mobile, 320px mobile, breakpoint transition, and reasoning selection passed.
  • Independent review of 0524344c3: no P0–P2 findings.
  • Slim pass: two files, 18 additions and 42 deletions; every changed hunk supports the approved behavior.

Before: 4363ba27d · After: 0524344c3 · Captured at 2× from the branch web app.

Viewport Before After
Desktop · 1440 × 900 Before desktop After desktop
Mobile · 390 × 844 Before mobile After mobile
Narrow mobile · 320 × 844 Before narrow mobile After narrow mobile

Very long or numerous provider-defined reasoning labels can still exceed a single row.

BB-Thread-ID: thr_jyt4i4y7p8

AGENT GENERATED

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T12:09:30.527278Z 0524344 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0524344c38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}}
disabled={selectionBlocked}
className={reasoningLadderClassName(reasoningOptions)}
className="flex gap-1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve access to overflowing reasoning options

When a model supplies long provider-defined labels or a crowded reasoning ladder, this non-wrapping flex row combines with each item's shrink-0 whitespace-nowrap and can exceed the picker's max-w-80; the desktop PopoverContent in ModelReasoningPicker.tsx:1047-1052 also has overflow-hidden, so trailing reasoning choices become clipped and cannot be seen or clicked. These inputs are supported, and the updated test itself includes long seven-option ladders that the previous adaptive grid handled. Keep the single row only when it fits, or provide a compact/scrollable fallback for arbitrary labels.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant