Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0524344c38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }} | ||
| disabled={selectionBlocked} | ||
| className={reasoningLadderClassName(reasoningOptions)} | ||
| className="flex gap-1" |
There was a problem hiding this comment.
Preserve access to overflowing reasoning options
When a model supplies long provider-defined labels or a crowded reasoning ladder, this non-wrapping flex row combines with each item's shrink-0 whitespace-nowrap and can exceed the picker's max-w-80; the desktop PopoverContent in ModelReasoningPicker.tsx:1047-1052 also has overflow-hidden, so trailing reasoning choices become clipped and cannot be seen or clicked. These inputs are supported, and the updated test itself includes long seven-option ladders that the previous adaptive grid handled. Keep the single row only when it fits, or provide a compact/scrollable fallback for arbitrary labels.
Useful? React with 👍 / 👎.
Human comments
What was wrong
Reasoning options switched to a two-row grid based on label length, making the model picker wrap. Restoring the original single row also exposed clipping on narrow phones.
What changed
How you verified
0524344c3. Run.0524344c3: no P0–P2 findings.Before:
4363ba27d· After:0524344c3· Captured at 2× from the branch web app.Very long or numerous provider-defined reasoning labels can still exceed a single row.
BB-Thread-ID: thr_jyt4i4y7p8