Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add-resource] New Theme & Skeleton: Hadron #3889

Open
chraebsli opened this issue Jan 16, 2025 · 7 comments
Open

[add-resource] New Theme & Skeleton: Hadron #3889

chraebsli opened this issue Jan 16, 2025 · 7 comments

Comments

@chraebsli
Copy link

I'm creating a new Theme with an included Skeleton: Hadron. It is a theme based on Quark with more features and some enhancements. I'm still full in development because I have many things in my head I like to add, but it is ready to be used and I use it for almost 10 websites now.

Details please see in the repo:

You are welcome to reach out when you have ideas yourself or some useful feedback!

@rhukster
Copy link
Member

Added to GPM for next update

@chraebsli
Copy link
Author

@rhukster I've noticed that only the theme is in the gpm. Did you add that too?

@rhukster
Copy link
Member

I can see a 'getRelease' failure for the skeleton.

It could be a couple of things in your blueprints, so best to just address them both:

  1. You use "Hadron" for name, this might clash with your theme, change it to "Hadron Site" or "Hadron Skeleton"
  2. You don't have a 'screenshot.jpg' and 'thumb.jpg'. this is required as the GPM on the site, shows a thumbnail image for each skeleton. Top tip, you an use the ones from the Hadron theme.

The issue probably is just #2, but best to have a unique name also.

@rhukster rhukster reopened this Jan 24, 2025
@chraebsli
Copy link
Author

@rhukster Thanks for the feedback, I just updated the skeleton repo with the changes. Please check again..

@rhukster
Copy link
Member

Still failing on get release. I think the problem is this stray v0.1.0 tag that because it's got the v is looking like its the latest. Delete this tag and i think you should be good.

Image

@chraebsli
Copy link
Author

fixed now

@rhukster
Copy link
Member

rhukster commented Feb 3, 2025

Ok, the most obvious thing I forgot to check turns out is the issue. You have created a release but don't have a 'build' that includes everthing needed. You should check out this blog post:

https://getgrav.org/blog/skeletons-build-automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants