Disabling calendar service name causes ical integration to fail

[prostolyubo]

Description

As explained in #2651 to hide a service name (specificly a callendar) we are advised to type nothing as a service name:

- CalendarGroup:
  - "":
    widget: 
      type: calendar

which works untill we add an integration, because then the API call fails:
http://myhost:3000/api/services/proxy?group=CalendarGroup&service=&endpoint=...
My gues is that service=& causes the api to fail and display an error:

I propose to simply add a flag to a service similar to groups: header: false that would disable the service name. I think it can be useful even with other widgets than calendar.

homepage version

v0.9.5 (eccd96a)

Installation method

Docker

Configuration

No response

Container Logs

No response

Browser Logs

No response

Troubleshooting

From the network inspection I can see that

curl 'http://hptheti:3000/api/services/proxy?group=Calendar&service=&endpoint=Heti&query=%7B%22refreshInterval%22%3A300000%7D' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-US,en;q=0.9,pl;q=0.8' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Cookie: remember_token_P5001=<redacted>csrf_token_P5001=<redacted>session_P5001=<redacted>_gorilla_csrf=<redacted>portainer_api_key=<redacted>' \
  -H 'Pragma: no-cache' \
  -H 'Referer: http://myhost:3000/' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36' \
  --insecure

returns

{"error":"Invalid integration"}

It is not integration's fault, because if a service name is provided instead of an empty "" everything works fine.

[shamoon]

This isn't a bug, you're doing something basically unsupported. You can always hide the title with CSS if that's all you're trying to do.

[prostolyubo]

And that's exactly my current workaround. But it would be nice to have such a feature. I think I can do it, the question is: is the community interested?

[JMOdero]

I know a calendar when I see it. I don't need to be told.

I know there are other bigger issues, but it would be nice if there was a built in way to remove this unnecessary title/label. As @prostolyubo mentioned it could be a good feature for other services and widgets.

I appreciate all the hard work that has been put into this wonderful application. This post is a mere trifling quibble vs a complaint... really more of a humble small request.

[github-actions[bot]]

This discussion has been automatically closed due to inactivity. See our contributing guidelines for more details.