Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer keeps open when browser back/forward used #6030

Open
afbora opened this issue Nov 30, 2023 · 9 comments · Fixed by #6363 · May be fixed by #6620
Open

Drawer keeps open when browser back/forward used #6030

afbora opened this issue Nov 30, 2023 · 9 comments · Fixed by #6363 · May be fixed by #6620
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@afbora
Copy link
Member

afbora commented Nov 30, 2023

Description

  1. Go to panel site dashboard
  2. Than go to any page that have blocks/layout/structure field (for drawer)
  3. For ex: edit any block item and you'll see drawer open
  4. Then use browser back (without click, for ex with mouse back key)
  5. See issue that you'll redirected to site dashboard but drawer still open

Your setup

Kirby Version
4.0.0

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Nov 30, 2023
@bastianallgeier bastianallgeier added the needs: replication 🔬 Requires a sample to reproduce the issue label Nov 30, 2023
@bastianallgeier
Copy link
Member

I cannot replicate this unfortunately.

@afbora
Copy link
Member Author

afbora commented Nov 30, 2023

@bastianallgeier Ah I found correct steps. Issue happened with structure field in blocks field.

  1. Go to panel site dashboard
  2. Then go to any page that have blocks field that have structure field (for drawer)
  3. For ex: edit any block item and you'll see drawer open
  4. Then edit a structure row
  5. Use browser back while you editing a input in structure row (without click, for ex with mouse back key)
  6. See issue that you'll redirected to site dashboard but drawer still open

@afbora
Copy link
Member Author

afbora commented Nov 30, 2023

I think this issue related with nested blocks not with just structure field in blocks field.

Copy link
Contributor

This issue has been marked as stale because it requires further input but has not seen activity in the past months. This is for us to prioritize issues that are still relevant and actionable. It will be closed if no further activity occurs within the next 15 days. If this issue is still relevant to you, please help us in gathering the necessary input.

@github-actions github-actions bot added the type: stale 💤 Will be closed soon because there was no recent activity label Jan 30, 2024
@afbora afbora removed the type: stale 💤 Will be closed soon because there was no recent activity label Jan 30, 2024
@afbora
Copy link
Member Author

afbora commented Jan 30, 2024

Stil valid issue for me in 4.1.0-RC3:

drawer.mp4

@afbora
Copy link
Member Author

afbora commented Jan 30, 2024

Also getting console error:

TypeError: Cannot read properties of null (reading '$invalid')

@distantnative
Copy link
Member

@bastianallgeier could this be related to #6274 ?

@distantnative distantnative linked a pull request Mar 24, 2024 that will close this issue
2 tasks
@distantnative
Copy link
Member

@afbora I think he other issue is indeed the same. The key part was that it's about not a normal drawer, but a nested drawer open. And so on back, only one drawer level closes instead of all.

Could you please test if #6363 also solves this issue?

@distantnative distantnative self-assigned this Mar 24, 2024
@distantnative distantnative removed the needs: replication 🔬 Requires a sample to reproduce the issue label Mar 24, 2024
@distantnative distantnative added this to the 4.2.0 milestone Mar 24, 2024
@afbora
Copy link
Member Author

afbora commented Mar 25, 2024

@distantnative That PR solves the issue only partially. After browser back still a shadow layer visible. It's gone when you click to anywhere.

@bastianallgeier bastianallgeier modified the milestones: 4.2.0, 4.2.x Mar 27, 2024
distantnative added a commit that referenced this issue Aug 15, 2024
@distantnative distantnative modified the milestones: 4.4.x, 4.5.0 Aug 15, 2024
@distantnative distantnative linked a pull request Aug 15, 2024 that will close this issue
4 tasks
@distantnative distantnative modified the milestones: 4.5.0, 4.4.0 Aug 15, 2024
@afbora afbora linked a pull request Aug 16, 2024 that will close this issue
4 tasks
@distantnative distantnative modified the milestones: 4.4.0, 4.5.0 Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
3 participants