Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.methodOverwrite config option and check #6650

Merged
merged 2 commits into from
Oct 1, 2024
Merged

api.methodOverwrite config option and check #6650

merged 2 commits into from
Oct 1, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 31, 2024 •
edited
Loading

Description

Summary of changes

  • Switching default to use pure PATCH requests etc. without x-http-method-override header
  • New api.methodOverwrite config option to activate x-http-method-override header
  • New check in system settings that shows error if PATCH requests don't work

Reasoning

https://forum.getkirby.com/t/kirby-panel-not-editable-with-bunny-cdn/32215

Changelog

Enhancements

  • api.methodOverwrite config option to activate pure PATCH requests

Docs

  • Add api.methodOverwrite config option docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Aug 31, 2024
@distantnative distantnative added this to the 4.5.0 milestone Aug 31, 2024
@distantnative distantnative self-assigned this Aug 31, 2024
@distantnative distantnative linked an issue Aug 31, 2024 that may be closed by this pull request
Config option: disable PATCH methodOverwrite #6636
Closed
@distantnative distantnative force-pushed the enhancement/6636-http-method-override branch from a195121 to 924a0d1 Compare August 31, 2024 12:28
@distantnative distantnative force-pushed the enhancement/6636-http-method-override branch from 924a0d1 to 2f9bd7a Compare September 12, 2024 18:31
@distantnative distantnative force-pushed the enhancement/6636-http-method-override branch from 2f9bd7a to 3df6950 Compare September 20, 2024 14:41
bastianallgeier
bastianallgeier reviewed Oct 1, 2024
View reviewed changes
src/Panel/View.php Outdated Show resolved Hide resolved
bastianallgeier
bastianallgeier reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this new option and it would be great if we could get this PR done.

@distantnative distantnative force-pushed the enhancement/6636-http-method-override branch from 3df6950 to 62122e4 Compare October 1, 2024 16:51
@distantnative distantnative marked this pull request as ready for review October 1, 2024 16:55
@distantnative distantnative merged commit 4938fa2 into develop-minor Oct 1, 2024
15 of 16 checks passed
@distantnative distantnative deleted the enhancement/6636-http-method-override branch October 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@lukasbestle lukasbestle Awaiting requested review from lukasbestle

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Config option: disable PATCH methodOverwrite
2 participants
@distantnative @bastianallgeier