PR #389 #1090
cameroncookecodeql
on: dynamic
Matrix: analyze
Annotations
2 warnings
|
Swift Testing run summary can decrement completed/failed counts:
src/utils/xcodebuild-event-parser.ts#L354
The new summary handling computes `completedCount += stSummary.executed - swiftTestingCompletedSinceSummary` (and similarly for failed). If per-test result lines counted more cases than the summary reports (e.g., due to retries, repeated lines, or parser overcounting), the delta becomes negative and the cumulative counters move backwards. The previous `Math.max` guard prevented regressions; the new logic does not. Consequence: emitted `test-progress` fragments could show fewer completed/failed tests than were actually observed, producing visibly inconsistent progress in the CLI.
|
|
[AJK-GZ9] Swift Testing run summary can decrement completed/failed counts (additional location):
src/utils/xcodebuild-event-parser.ts#L352
The new summary handling computes `completedCount += stSummary.executed - swiftTestingCompletedSinceSummary` (and similarly for failed). If per-test result lines counted more cases than the summary reports (e.g., due to retries, repeated lines, or parser overcounting), the delta becomes negative and the cumulative counters move backwards. The previous `Math.max` guard prevented regressions; the new logic does not. Consequence: emitted `test-progress` fragments could show fewer completed/failed tests than were actually observed, producing visibly inconsistent progress in the CLI.
|