PR #397 #1184
cameroncookecodeql
on: dynamic
Matrix: analyze
Annotations
2 errors and 3 warnings
|
Import uses '.ts' extension instead of '.js', breaking module resolution:
src/utils/xcodebuild-domain-results.ts#L31
The new import on line 31 uses `./xcresult-test-failures.ts` while every other relative import in this file uses the `.js` extension required by the project's ESM/NodeNext module resolution. After TypeScript compilation, the emitted import will still reference a `.ts` file that does not exist at runtime, causing a module-not-found error and preventing the test domain result code path from loading. This breaks the entire feature being added.
|
|
Import uses '.ts' extension instead of '.js', breaking production build and module resolution conventions:
src/utils/xcodebuild-domain-results.ts#L31
The new import `from './xcresult-test-failures.ts'` uses a `.ts` extension, while every other relative import in this file uses `.js` (the project's Node16 ESM convention). The build config (`tsconfig.build.json`) explicitly sets `allowImportingTsExtensions: false`, so this import will fail the production TypeScript build. Even at runtime under Node16 ESM, resolution expects the emitted `.js` path. This will break compilation/packaging of the module.
|
|
Analyze (actions)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses.
To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
|
|
Analyze (javascript-typescript)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses.
To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
|
|
Import uses .ts extension instead of .js:
src/utils/xcodebuild-domain-results.ts#L31
The new import uses a `.ts` extension, which is inconsistent with all other imports in this file (and project standards) that use `.js` extensions for ES module imports. This breaks the project's established ES module import convention and will likely fail at runtime since compiled output uses `.js`.
|