Skip to content

PR #397

PR #397 #1188

Triggered via dynamic May 6, 2026 20:47
Status Success
Total duration 1m 17s
Artifacts

codeql

on: dynamic
Matrix: analyze
Fit to window
Zoom out
Zoom in

Annotations

4 warnings
Analyze (python)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
Analyze (javascript-typescript)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
Successful summary reports a 'failed' count that is always nonzero only when status is wrong: src/utils/renderers/event-formatting.ts#L514
When `succeeded` is true, the status is `SUCCEEDED`, which by definition means no tests failed. Adding `${failed} failed` to the success branch will always render `0 failed` (or worse, a misleading nonzero value if the status flag and counts ever disagree), cluttering the success message with redundant information. This is a user-visible regression in the summary output for passing test runs.
Import uses .ts extension instead of .js: src/utils/xcodebuild-domain-results.ts#L31
The new import from './xcresult-test-failures.ts' uses a `.ts` extension, but the rest of the file (and project standard per CLAUDE.md) uses ES module imports with `.js` extensions. This inconsistency violates the project standard for ES module imports and will likely fail at runtime after compilation since the emitted JS will reference a non-existent `.ts` file.