Skip to content

Commit 244f5c8

Browse files
committed
fix(ui-automation): Preserve inactive tab value hints
Keep value-based toggle filtering scoped away from tab elements so inactive tabs with compact values such as 0/off still remain eligible as screen-changing next-step suggestions.
1 parent f085155 commit 244f5c8

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/mcp/tools/ui-automation/__tests__/runtime-next-steps.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ describe('runtime snapshot next steps', () => {
118118
type: 'Tab',
119119
role: 'AXTab',
120120
AXLabel: 'Search',
121-
AXValue: 'not selected',
121+
AXValue: '0',
122122
AXSelected: false,
123123
}),
124124
]);

src/mcp/tools/ui-automation/shared/runtime-next-steps.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,10 @@ function isStateChangingTapNextStepElement(element: {
8989
value === 'selected' ||
9090
(element.role !== 'tab' && (element.state?.selected === false || value === 'not selected'));
9191

92-
return (
93-
element.role === 'switch' ||
94-
hasSelectionState ||
95-
value === '0' ||
96-
value === '1' ||
97-
value === 'off' ||
98-
value === 'on'
99-
);
92+
const hasToggleValue =
93+
element.role !== 'tab' && (value === '0' || value === '1' || value === 'off' || value === 'on');
94+
95+
return element.role === 'switch' || hasSelectionState || hasToggleValue;
10096
}
10197

10298
/**

0 commit comments

Comments
 (0)