fix(example): Address Weather review follow-ups

cameroncooke · codex · cameroncooke · commit 4671239c670b · 2026-05-05T23:34:33.000+01:00
Plumb dew point and location subtitles through the Weather example and
make cancelled location searches clear their current loading state safely.

Co-Authored-By: OpenAI Codex &lt;noreply@openai.com&gt;
diff --git a/example_projects/Weather/Schemas/weather-report.schema.json b/example_projects/Weather/Schemas/weather-report.schema.json
@@ -26,6 +26,9 @@
             "feelsLikeC": {
               "type": "integer"
             },
+            "dewPointC": {
+              "type": "integer"
+            },
             "condition": {
               "type": "string",
               "enum": [
@@ -160,6 +163,7 @@
             "highC",
             "lowC",
             "feelsLikeC",
+            "dewPointC",
             "condition",
             "solarProgress",
             "sunrise",
@@ -347,6 +351,9 @@
             "feelsLikeC": {
               "type": "integer"
             },
+            "dewPointC": {
+              "type": "integer"
+            },
             "condition": {
               "type": "string",
               "enum": [
@@ -481,6 +488,7 @@
             "highC",
             "lowC",
             "feelsLikeC",
+            "dewPointC",
             "condition",
             "solarProgress",
             "sunrise",
diff --git a/example_projects/Weather/Weather/ContentView.swift b/example_projects/Weather/Weather/ContentView.swift
@@ -51,6 +51,7 @@ struct ContentView: View {
             if let report, let selectedLocation {
                 AtmosWeatherScreen(
                     locationName: selectedLocation.name,
+                    locationSubtitle: selectedLocation.subtitle,
                     current: report.current,
                     hourly: report.hourly,
                     daily: report.daily,
diff --git a/example_projects/Weather/Weather/Models/WeatherModels.swift b/example_projects/Weather/Weather/Models/WeatherModels.swift
@@ -106,6 +106,7 @@ struct CurrentWeather: Equatable, Identifiable, Sendable {
     let highC: Int
     let lowC: Int
     let feelsLikeC: Int
+    let dewPointC: Int
     let condition: WeatherCondition
     let solarProgress: SolarDayProgress
     let sunrise: LocalClockTime
diff --git a/example_projects/Weather/Weather/Services/MockWeatherDTOFactories.swift b/example_projects/Weather/Weather/Services/MockWeatherDTOFactories.swift
@@ -85,39 +85,39 @@ extension CurrentWeatherDTO {
         case .clearDay:
             CurrentWeatherDTO(
                 id: "weather-current-loc-current-san-francisco",
-                temperatureC: 18, highC: 20, lowC: 12, feelsLikeC: 17, condition: .mostlySunny,
+                temperatureC: 18, highC: 20, lowC: 12, feelsLikeC: 17, dewPointC: 9, condition: .mostlySunny,
                 solarProgress: .daylight(0.62), sunrise: clock(6, 18), sunset: clock(19, 42), airQualityIndex: 38, airQualityCategory: .good,
                 uvIndex: 6, uvCategory: .high, windKph: 13, windDirectionDegrees: 292, humidity: 64,
                 visibilityKilometers: 16.1, pressureMillibars: 1018, pressureTrend: .rising, precipChance: 5
             )
         case .rainy:
             CurrentWeatherDTO(
                 id: "weather-current-loc-us-or-portland",
-                temperatureC: 11, highC: 13, lowC: 9, feelsLikeC: 9, condition: .lightRain,
+                temperatureC: 11, highC: 13, lowC: 9, feelsLikeC: 9, dewPointC: 8, condition: .lightRain,
                 solarProgress: .daylight(0.45), sunrise: clock(6, 42), sunset: clock(19, 18), airQualityIndex: 22, airQualityCategory: .good,
                 uvIndex: 1, uvCategory: .low, windKph: 23, windDirectionDegrees: 225, humidity: 89,
                 visibilityKilometers: 9.7, pressureMillibars: 1006, pressureTrend: .falling, precipChance: 78
             )
         case .snowy:
             CurrentWeatherDTO(
                 id: "weather-current-loc-us-co-aspen",
-                temperatureC: -4, highC: -2, lowC: -10, feelsLikeC: -8, condition: .lightSnow,
+                temperatureC: -4, highC: -2, lowC: -10, feelsLikeC: -8, dewPointC: -7, condition: .lightSnow,
                 solarProgress: .daylight(0.50), sunrise: clock(7, 14), sunset: clock(17, 38), airQualityIndex: 18, airQualityCategory: .good,
                 uvIndex: 2, uvCategory: .low, windKph: 10, windDirectionDegrees: 0, humidity: 78,
                 visibilityKilometers: 6.4, pressureMillibars: 1022, pressureTrend: .steady, precipChance: 65
             )
         case .night:
             CurrentWeatherDTO(
                 id: "weather-current-loc-is-reykjavik",
-                temperatureC: 3, highC: 6, lowC: 1, feelsLikeC: 1, condition: .clearNight,
+                temperatureC: 3, highC: 6, lowC: 1, feelsLikeC: 1, dewPointC: 0, condition: .clearNight,
                 solarProgress: .afterSunset, sunrise: clock(5, 46), sunset: clock(20, 24), airQualityIndex: 12, airQualityCategory: .good,
                 uvIndex: 0, uvCategory: .none, windKph: 6, windDirectionDegrees: 45, humidity: 71,
                 visibilityKilometers: 16.1, pressureMillibars: 1014, pressureTrend: .steady, precipChance: 8
             )
         case .stormy:
             CurrentWeatherDTO(
                 id: "weather-current-loc-us-la-new-orleans",
-                temperatureC: 22, highC: 26, lowC: 20, feelsLikeC: 24, condition: .thunderstorms,
+                temperatureC: 22, highC: 26, lowC: 20, feelsLikeC: 24, dewPointC: 19, condition: .thunderstorms,
                 solarProgress: .daylight(0.78), sunrise: clock(6, 8), sunset: clock(19, 52), airQualityIndex: 55, airQualityCategory: .moderate,
                 uvIndex: 3, uvCategory: .moderate, windKph: 35, windDirectionDegrees: 180, humidity: 86,
                 visibilityKilometers: 4.8, pressureMillibars: 998, pressureTrend: .falling, precipChance: 92
diff --git a/example_projects/Weather/Weather/Services/WeatherClientDTOs.swift b/example_projects/Weather/Weather/Services/WeatherClientDTOs.swift
@@ -34,6 +34,7 @@ struct CurrentWeatherDTO: Codable, Equatable, Sendable {
     let highC: Int
     let lowC: Int
     let feelsLikeC: Int
+    let dewPointC: Int
     let condition: WeatherConditionDTO
     let solarProgress: SolarDayProgressDTO
     let sunrise: LocalClockTimeDTO
@@ -202,6 +203,7 @@ extension CurrentWeather {
             highC: dto.highC,
             lowC: dto.lowC,
             feelsLikeC: dto.feelsLikeC,
+            dewPointC: dto.dewPointC,
             condition: WeatherCondition(dto: dto.condition),
             solarProgress: try SolarDayProgress(dto: dto.solarProgress),
             sunrise: try LocalClockTime(dto: dto.sunrise),
diff --git a/example_projects/Weather/Weather/Views/AtmosWeatherScreen.swift b/example_projects/Weather/Weather/Views/AtmosWeatherScreen.swift
@@ -2,6 +2,7 @@ import SwiftUI
 
 struct AtmosWeatherScreen: View {
     let locationName: String
+    let locationSubtitle: String
     let current: CurrentWeather
     let hourly: [HourlyForecast]
     let daily: [DailyForecast]
@@ -17,7 +18,7 @@ struct AtmosWeatherScreen: View {
 
                 ScrollView {
                     VStack(spacing: 0) {
-                        WeatherHeroView(locationName: locationName, current: current, units: units)
+                        WeatherHeroView(locationName: locationName, locationSubtitle: locationSubtitle, current: current, units: units)
 
                         VStack(spacing: 10) {
                             HourlyForecastCard(forecasts: hourly, current: current, units: units)
diff --git a/example_projects/Weather/Weather/Views/Overlays/LocationPickerView.swift b/example_projects/Weather/Weather/Views/Overlays/LocationPickerView.swift
@@ -197,6 +197,11 @@ struct LocationPickerView: View {
         isLoading = true
         searchErrorMessage = nil
         let currentQuery = query
+        defer {
+            if currentQuery == query {
+                isLoading = false
+            }
+        }
 
         do {
             let matches = try await weatherService.searchLocations(matching: currentQuery)
@@ -207,8 +212,6 @@ struct LocationPickerView: View {
             results = []
             searchErrorMessage = "Search is unavailable right now."
         }
-
-        isLoading = false
     }
 
     private func isSaved(_ location: WeatherLocation) -> Bool {
diff --git a/example_projects/Weather/Weather/Views/Sections/ConditionGrid.swift b/example_projects/Weather/Weather/Views/Sections/ConditionGrid.swift
@@ -15,7 +15,7 @@ struct ConditionGrid: View {
                 ConditionTile(title: "UV INDEX", value: "\(current.uvIndex)", caption: current.uvLabel, current: current) {
                     UVViz(value: current.uvIndex, theme: current.theme)
                 }
-                ConditionTile(title: "HUMIDITY", value: "\(current.humidity)%", caption: "Dew point: \(WeatherUnitFormatter.temperature(9, units: units))°", current: current) {
+                ConditionTile(title: "HUMIDITY", value: "\(current.humidity)%", caption: "Dew point: \(WeatherUnitFormatter.temperature(current.dewPointC, units: units))°", current: current) {
                     FilledBar(value: Double(current.humidity) / 100, theme: current.theme)
                 }
                 ConditionTile(
diff --git a/example_projects/Weather/Weather/Views/Sections/WeatherHeroView.swift b/example_projects/Weather/Weather/Views/Sections/WeatherHeroView.swift
@@ -2,6 +2,7 @@ import SwiftUI
 
 struct WeatherHeroView: View {
     let locationName: String
+    let locationSubtitle: String
     let current: CurrentWeather
     let units: WeatherUnits
 
@@ -12,7 +13,7 @@ struct WeatherHeroView: View {
                 .tracking(-0.3)
                 .accessibilityIdentifier("weather.heroLocation")
 
-            Text("My Location")
+            Text(locationSubtitle)
                 .font(.system(size: 13))
                 .tracking(0.2)
                 .foregroundStyle(current.theme.foregroundMuted)
diff --git a/example_projects/Weather/WeatherTests/Fixtures/weather-report-loc-current-san-francisco.json b/example_projects/Weather/WeatherTests/Fixtures/weather-report-loc-current-san-francisco.json
@@ -5,6 +5,7 @@
     "highC": 20,
     "lowC": 12,
     "feelsLikeC": 17,
+    "dewPointC": 9,
     "condition": "mostly_sunny",
     "solarProgress": {
       "kind": "daylight",
@@ -84,6 +85,7 @@
     "highC": 13,
     "lowC": 9,
     "feelsLikeC": 9,
+    "dewPointC": 8,
     "condition": "light_rain",
     "solarProgress": {
       "kind": "daylight",
diff --git a/example_projects/Weather/WeatherTests/WeatherTests.swift b/example_projects/Weather/WeatherTests/WeatherTests.swift
@@ -77,6 +77,7 @@ struct WeatherTests {
             highC: 20,
             lowC: 12,
             feelsLikeC: 17,
+            dewPointC: 9,
             condition: .mostlySunny,
             solarProgress: .daylightFraction(0.62),
             sunrise: LocalClockTime(hour: 6, minute: 18),
@@ -196,6 +197,7 @@ struct WeatherTests {
             highC: 12,
             lowC: 8,
             feelsLikeC: 9,
+            dewPointC: 8,
             condition: .sunny,
             solarProgress: SolarDayProgressDTO(kind: .daylight, daylightFraction: 0.5),
             sunrise: LocalClockTimeDTO(hour: 6, minute: 0),
@@ -228,6 +230,7 @@ struct WeatherTests {
                 highC: 20,
                 lowC: 12,
                 feelsLikeC: 17,
+                dewPointC: 9,
                 condition: .mostlySunny,
                 solarProgress: SolarDayProgressDTO(kind: .daylight, daylightFraction: 0.62),
                 sunrise: LocalClockTimeDTO(hour: 6, minute: 18),
@@ -284,6 +287,7 @@ struct WeatherTests {
                 highC: 13,
                 lowC: 9,
                 feelsLikeC: 9,
+                dewPointC: 8,
                 condition: .lightRain,
                 solarProgress: SolarDayProgressDTO(kind: .daylight, daylightFraction: 0.45),
                 sunrise: LocalClockTimeDTO(hour: 6, minute: 42),

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ struct ConditionGrid: View {`
`15`	`15`	`ConditionTile(title: "UV INDEX", value: "\(current.uvIndex)", caption: current.uvLabel, current: current) {`
`16`	`16`	`UVViz(value: current.uvIndex, theme: current.theme)`
`17`	`17`	`}`
`18`		`- ConditionTile(title: "HUMIDITY", value: "\(current.humidity)%", caption: "Dew point: \(WeatherUnitFormatter.temperature(9, units: units))°", current: current) {`
	`18`	`+ ConditionTile(title: "HUMIDITY", value: "\(current.humidity)%", caption: "Dew point: \(WeatherUnitFormatter.temperature(current.dewPointC, units: units))°", current: current) {`
`19`	`19`	`FilledBar(value: Double(current.humidity) / 100, theme: current.theme)`
`20`	`20`	`}`
`21`	`21`	`ConditionTile(`