Skip to content

Commit 52a0b3a

Browse files
committed
Remove Smithery config overrides for consistent behavior
Smithery entry point now behaves identically to index.ts: - No CLI flag config options - All configuration via config.yaml and env vars - Same precedence: config.yaml > env vars > defaults This aligns with the vision of config.yaml as canonical truth. Also removes unused xcodemake imports from index.ts.
1 parent 6a9afd6 commit 52a0b3a

2 files changed

Lines changed: 5 additions & 50 deletions

File tree

src/index.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ import { getDefaultDebuggerManager } from './utils/debugger/index.ts';
2424
// Import version
2525
import { version } from './version.ts';
2626

27-
// Import xcodemake utilities
28-
import { isXcodemakeEnabled, isXcodemakeAvailable } from './utils/xcodemake.ts';
29-
3027
// Import process for stdout configuration
3128
import process from 'node:process';
3229

@@ -39,22 +36,6 @@ async function main(): Promise<void> {
3936
try {
4037
initSentry();
4138

42-
// Check if xcodemake is enabled and available
43-
if (isXcodemakeEnabled()) {
44-
log('info', 'xcodemake is enabled, checking if available...');
45-
const available = await isXcodemakeAvailable();
46-
if (available) {
47-
log('info', 'xcodemake is available and will be used for builds');
48-
} else {
49-
log(
50-
'warn',
51-
'xcodemake is enabled but could not be made available, falling back to xcodebuild',
52-
);
53-
}
54-
} else {
55-
log('debug', 'xcodemake is disabled, using standard xcodebuild');
56-
}
57-
5839
// Create the server
5940
const server = createServer();
6041

src/smithery.ts

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,44 +4,18 @@ import { bootstrapServer } from './server/bootstrap.ts';
44
import { createServer } from './server/server.ts';
55
import { log } from './utils/logger.ts';
66
import { initSentry } from './utils/sentry.ts';
7-
import type { RuntimeConfigOverrides } from './utils/config-store.ts';
87

9-
export const configSchema = z.object({
10-
incrementalBuildsEnabled: z
11-
.boolean()
12-
.default(false)
13-
.describe('Enable incremental builds via xcodemake (true/false).'),
14-
enabledWorkflows: z
15-
.string()
16-
.default('')
17-
.describe('Comma-separated list of workflows to load at startup.'),
18-
debug: z.boolean().default(false).describe('Enable debug logging.'),
19-
});
8+
// Empty config schema - all configuration comes from config.yaml and env vars
9+
export const configSchema = z.object({});
2010

2111
export type SmitheryConfig = z.infer<typeof configSchema>;
2212

23-
function parseEnabledWorkflows(value: string): string[] {
24-
return value
25-
.split(',')
26-
.map((name) => name.trim().toLowerCase())
27-
.filter(Boolean);
28-
}
29-
30-
function buildOverrides(config: SmitheryConfig): RuntimeConfigOverrides {
31-
return {
32-
incrementalBuildsEnabled: config.incrementalBuildsEnabled,
33-
debug: config.debug,
34-
enabledWorkflows: parseEnabledWorkflows(config.enabledWorkflows),
35-
};
36-
}
37-
38-
export default function createSmitheryServer({ config }: { config: SmitheryConfig }): McpServer {
39-
const overrides = buildOverrides(config);
40-
13+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
14+
export default function createSmitheryServer(options: { config: SmitheryConfig }): McpServer {
4115
const server = createServer();
4216
const bootstrapPromise: Promise<void> = (async (): Promise<void> => {
4317
initSentry();
44-
await bootstrapServer(server, { configOverrides: overrides });
18+
await bootstrapServer(server);
4519
})().catch((error) => {
4620
log(
4721
'error',

0 commit comments

Comments
 (0)