Skip to content

Commit e3e2ee5

Browse files
committed
docs(agents): scope review focus to branch regressions
Add a guidance line to AGENTS.md and CLAUDE.md telling reviewers to focus on behavior changes caused by the current branch and to ignore known test flakes, environment setup issues, and nondeterministic tool output churn unless explicitly asked to investigate them.
1 parent 264119a commit e3e2ee5

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

AGENTS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ Use these sections under `## [Unreleased]`:
6161
- Common hang causes: locked physical device, stale simulator state, `devicectl diagnose` waiting for password, orphaned daemon process.
6262
- Capture what you find before killing, so the root cause can be fixed rather than papered over.
6363
- If physical-device snapshot tests hang after the final test summary, the likely cause is Apple post-failure diagnostics invoking `devicectl diagnose`, which may prompt for a macOS password and wedge in automated runs.
64+
- When asked to review changes or test failures, focus on regressions: behavior changes caused by the branch. Do not treat known/acceptable test flakes, environment setup issues, or nondeterministic tool output churn as regressions unless explicitly asked to investigate them.
6465

6566
## **CRITICAL** Tool Usage Rules **CRITICAL**
6667
- NEVER use sed/cat to read a file or a range of a file. Always use the native read tool.

CLAUDE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ Use these sections under `## [Unreleased]`:
6060
- Do NOT just kill the run — first inspect the process tree (`ps -ef | grep -E "vitest|xcodebuild|simctl|devicectl"`) to identify what's stuck.
6161
- Common hang causes: locked physical device, stale simulator state, `devicectl diagnose` waiting for password, orphaned daemon process.
6262
- Capture what you find before killing, so the root cause can be fixed rather than papered over.
63+
- When asked to review changes or test failures, focus on regressions: behavior changes caused by the branch. Do not treat known/acceptable test flakes, environment setup issues, or nondeterministic tool output churn as regressions unless explicitly asked to investigate them.
6364

6465
## **CRITICAL** Tool Usage Rules **CRITICAL**
6566
- NEVER use sed/cat to read a file or a range of a file. Always use the native read tool.

0 commit comments

Comments
 (0)