Skip to content

Commit ec5cbaf

Browse files
cameroncookecodex
andcommitted
ref(snapshot): Simplify failed test normalization
Reuse the filtered failed test case list instead of repeating the same predicate for both detection and filtering. Co-Authored-By: OpenAI Codex <codex@openai.com>
1 parent 0a873b1 commit ec5cbaf

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

src/snapshot-tests/json-normalize.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,9 @@ function testCaseSortKey(item: unknown): string {
115115

116116
function normalizeTestCases(items: unknown[]): unknown[] {
117117
const sorted = [...items].sort((a, b) => testCaseSortKey(a).localeCompare(testCaseSortKey(b)));
118+
const failed = sorted.filter((item) => isNormalizedTestCase(item) && item.status === 'failed');
118119

119-
const hasFailures = sorted.some((item) => isNormalizedTestCase(item) && item.status === 'failed');
120-
return hasFailures
121-
? sorted.filter((item) => isNormalizedTestCase(item) && item.status === 'failed')
122-
: sorted;
120+
return failed.length > 0 ? failed : sorted;
123121
}
124122

125123
function normalizeStderrLines(items: unknown[]): unknown[] {

0 commit comments

Comments
 (0)