Skip to content

Commit 7a9f14b

Browse files
fix(local): call server.close() before closeAllConnections()
The reverse order can prevent the close callback from firing when active SSE connections exist, causing the shutdown promise to hang.
1 parent ff3c8b8 commit 7a9f14b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/commands/local/run.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ const BUFFER_SIZE = 500;
4949
*/
5050
function shutdownServer(server: Server): Promise<void> {
5151
return new Promise<void>((resolve) => {
52+
server.close(() => resolve());
5253
if (typeof server.closeAllConnections === "function") {
5354
server.closeAllConnections();
5455
}
55-
server.close(() => resolve());
5656
});
5757
}
5858

0 commit comments

Comments
 (0)