Commit ebb31ba
committed
refactor(telemetry): use child spans for phase timing instead of manual measurement
Replace performance.now() markers and setPhaseTimingAttributes with
cli.command.exec and cli.command.render child spans. Span durations
are the idiomatic way to measure phases — they appear in the trace
waterfall and don't require custom attributes.
Updated the 'Command Phase Breakdown' dashboard widget to query
span.duration grouped by span.op instead of custom phase.* attributes.1 parent 86faa55 commit ebb31ba
2 files changed
Lines changed: 21 additions & 54 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 63 | + | |
68 | 64 | | |
69 | 65 | | |
70 | 66 | | |
| |||
526 | 522 | | |
527 | 523 | | |
528 | 524 | | |
529 | | - | |
530 | | - | |
531 | 525 | | |
532 | 526 | | |
533 | 527 | | |
| |||
579 | 573 | | |
580 | 574 | | |
581 | 575 | | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | 576 | | |
586 | 577 | | |
587 | 578 | | |
| |||
595 | 586 | | |
596 | 587 | | |
597 | 588 | | |
598 | | - | |
599 | | - | |
600 | | - | |
601 | | - | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
602 | 606 | | |
603 | | - | |
604 | | - | |
605 | | - | |
606 | | - | |
607 | | - | |
608 | | - | |
609 | | - | |
610 | | - | |
611 | | - | |
612 | | - | |
613 | | - | |
614 | | - | |
615 | 607 | | |
616 | | - | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
622 | 611 | | |
623 | 612 | | |
624 | 613 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
622 | | - | |
623 | | - | |
624 | | - | |
625 | | - | |
626 | | - | |
627 | | - | |
628 | | - | |
629 | | - | |
630 | | - | |
631 | | - | |
632 | | - | |
633 | | - | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | | - | |
638 | | - | |
639 | 617 | | |
640 | 618 | | |
641 | 619 | | |
| |||
0 commit comments