fix(init): avoid stale resume replays#1064
Merged
Merged
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 97.98%. Project has 4762 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.54% 81.62% +0.08%
==========================================
Files 369 369 —
Lines 25845 25907 +62
Branches 16888 16933 +45
==========================================
+ Hits 21074 21145 +71
- Misses 4771 4762 -9
- Partials 1770 1768 -2Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 06301f2. Configure here.
betegon
force-pushed
the
fix/init-stale-resume-replays
branch
from
06301f2 to
5e84078
Compare
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
betegon
force-pushed
the
fix/init-stale-resume-replays
branch
3 times, most recently
from
42984ba to
e521c8a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
betegon
force-pushed
the
fix/init-stale-resume-replays
branch
from
e521c8a to
821d48e
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops
sentry initfrom replaying state-changing workflow resumes after timeouts or stale-resume conflicts. Recovery now observes the current run state, ignores snapshots that still show the exact same suspended payload, and only continues once the run reaches a terminal state or a genuinely advanced suspension.Changes
_prevPhasesso prior file contents are not resent through apply-codemods recoveryTest Plan
pnpm exec vitest run test/lib/init/wizard-runner.test.tspnpm exec biome check --no-errors-on-unmatched src/lib/init/wizard-runner.ts src/lib/init/types.ts test/lib/init/wizard-runner.test.tsRollout
Pairs with getsentry/cli-init-api#172. Land and deploy the server change first so released clients stop treating stale resume conflicts as retryable 5xx responses.