Skip to content

Commit 11bbba3

Browse files
committed
ref: Make SentryProfilingConditionals private
1 parent 5fcb6a1 commit 11bbba3

File tree

8 files changed

+7
-57
lines changed

8 files changed

+7
-57
lines changed

Samples/iOS-SwiftUI/iOS-SwiftUI.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ targets:
3131
- ../../Sources/Sentry/Public/SentrySerializable.h
3232
- ../../Sources/Sentry/include/SentryTracer.h
3333
- ../../Sources/Sentry/include/SentryPerformanceTracker.h
34-
- ../../Sources/Sentry/Public/SentryProfilingConditionals.h
34+
- ../../Sources/Sentry/include/HybridPublic/SentryProfilingConditionals.h
3535
dependencies:
3636
- target: Sentry/Sentry
3737
- target: Sentry/SentrySwiftUI

Sentry.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
0354A22B2A134D9C003C3A04 /* SentryProfilerState.h in Headers */ = {isa = PBXBuildFile; fileRef = 0354A22A2A134D9C003C3A04 /* SentryProfilerState.h */; };
1111
03BCC38A27E1BF49003232C7 /* SentryTime.h in Headers */ = {isa = PBXBuildFile; fileRef = 03BCC38927E1BF49003232C7 /* SentryTime.h */; };
1212
03BCC38C27E1C01A003232C7 /* SentryTime.mm in Sources */ = {isa = PBXBuildFile; fileRef = 03BCC38B27E1C01A003232C7 /* SentryTime.mm */; };
13-
03BCC38E27E2A377003232C7 /* SentryProfilingConditionals.h in Headers */ = {isa = PBXBuildFile; fileRef = 03BCC38D27E2A377003232C7 /* SentryProfilingConditionals.h */; settings = {ATTRIBUTES = (Public, ); }; };
13+
03BCC38E27E2A377003232C7 /* SentryProfilingConditionals.h in Headers */ = {isa = PBXBuildFile; fileRef = 03BCC38D27E2A377003232C7 /* SentryProfilingConditionals.h */; settings = {ATTRIBUTES = (Private, ); }; };
1414
03F84D1E27DD414C008FE43F /* SentryBacktrace.hpp in Headers */ = {isa = PBXBuildFile; fileRef = 03F84D1227DD414C008FE43F /* SentryBacktrace.hpp */; };
1515
03F84D2027DD414C008FE43F /* SentryStackBounds.hpp in Headers */ = {isa = PBXBuildFile; fileRef = 03F84D1427DD414C008FE43F /* SentryStackBounds.hpp */; };
1616
03F84D2127DD414C008FE43F /* SentrySamplingProfiler.hpp in Headers */ = {isa = PBXBuildFile; fileRef = 03F84D1527DD414C008FE43F /* SentrySamplingProfiler.hpp */; };
@@ -1286,7 +1286,7 @@
12861286
035E73CD27D5790A005EEB11 /* SentryThreadMetadataCacheTests.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = SentryThreadMetadataCacheTests.mm; sourceTree = "<group>"; };
12871287
03BCC38927E1BF49003232C7 /* SentryTime.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SentryTime.h; path = Sources/Sentry/include/SentryTime.h; sourceTree = SOURCE_ROOT; };
12881288
03BCC38B27E1C01A003232C7 /* SentryTime.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = SentryTime.mm; path = Sources/Sentry/SentryTime.mm; sourceTree = SOURCE_ROOT; };
1289-
03BCC38D27E2A377003232C7 /* SentryProfilingConditionals.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentryProfilingConditionals.h; path = ../Public/SentryProfilingConditionals.h; sourceTree = "<group>"; };
1289+
03BCC38D27E2A377003232C7 /* SentryProfilingConditionals.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SentryProfilingConditionals.h; path = ../include/HybridPublic/SentryProfilingConditionals.h; sourceTree = "<group>"; };
12901290
03F84D1227DD414C008FE43F /* SentryBacktrace.hpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.h; name = SentryBacktrace.hpp; path = Sources/Sentry/include/SentryBacktrace.hpp; sourceTree = SOURCE_ROOT; };
12911291
03F84D1427DD414C008FE43F /* SentryStackBounds.hpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.h; name = SentryStackBounds.hpp; path = Sources/Sentry/include/SentryStackBounds.hpp; sourceTree = SOURCE_ROOT; };
12921292
03F84D1527DD414C008FE43F /* SentrySamplingProfiler.hpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.h; name = SentrySamplingProfiler.hpp; path = Sources/Sentry/include/SentrySamplingProfiler.hpp; sourceTree = SOURCE_ROOT; };

Sources/Resources/Sentry.modulemap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ framework module Sentry {
66

77
explicit module _Hybrid {
88
// Headers that are not part of the public API and should only be used by hybrid SDKs
9+
header "SentryProfilingConditionals.h"
910
header "PrivateSentrySDKOnly.h"
1011
header "PrivatesHeader.h"
1112
header "SentryAppStartMeasurement.h"

Sources/Sentry/Public/Sentry.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ FOUNDATION_EXPORT const unsigned char SentryVersionString[];
2929
# import <Sentry/SentryMechanismContext.h>
3030
# import <Sentry/SentryMessage.h>
3131
# import <Sentry/SentryNSError.h>
32-
# import <Sentry/SentryProfilingConditionals.h>
3332
# import <Sentry/SentryReplayApi.h>
3433
# import <Sentry/SentryRequest.h>
3534
# import <Sentry/SentrySampleDecision.h>

Sources/Sentry/Public/SentryWithoutUIKit.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ FOUNDATION_EXPORT const unsigned char SentryVersionString[];
2929
# import <SentryWithoutUIKit/SentryMechanismContext.h>
3030
# import <SentryWithoutUIKit/SentryMessage.h>
3131
# import <SentryWithoutUIKit/SentryNSError.h>
32-
# import <SentryWithoutUIKit/SentryProfilingConditionals.h>
3332
# import <SentryWithoutUIKit/SentryReplayApi.h>
3433
# import <SentryWithoutUIKit/SentryRequest.h>
3534
# import <SentryWithoutUIKit/SentrySampleDecision.h>

Sources/Sentry/include/SentryPrivate.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// This import must be first
2+
#import "SentryProfilingConditionals.h"
3+
14
// Sentry internal headers that are needed for swift code; you cannot import headers that depend on
25
// public interfaces here
36
#import "NSLocale+Sentry.h"

sdk_api.json

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -234,16 +234,6 @@
234234
"Exported"
235235
]
236236
},
237-
{
238-
"kind": "Import",
239-
"name": "Sentry.SentryProfilingConditionals",
240-
"printedName": "Sentry.SentryProfilingConditionals",
241-
"declKind": "Import",
242-
"moduleName": "Sentry",
243-
"declAttributes": [
244-
"Exported"
245-
]
246-
},
247237
{
248238
"kind": "Import",
249239
"name": "Sentry.SentryReplayApi",
@@ -57119,48 +57109,6 @@
5711957109
}
5712057110
]
5712157111
},
57122-
{
57123-
"kind": "Var",
57124-
"name": "SENTRY_TARGET_PROFILING_SUPPORTED",
57125-
"printedName": "SENTRY_TARGET_PROFILING_SUPPORTED",
57126-
"children": [
57127-
{
57128-
"kind": "TypeNominal",
57129-
"name": "Int32",
57130-
"printedName": "Swift.Int32",
57131-
"usr": "s:s5Int32V"
57132-
}
57133-
],
57134-
"declKind": "Var",
57135-
"usr": "c:@macro@SENTRY_TARGET_PROFILING_SUPPORTED",
57136-
"moduleName": "Sentry",
57137-
"declAttributes": [
57138-
"Nonisolated"
57139-
],
57140-
"accessors": [
57141-
{
57142-
"kind": "Accessor",
57143-
"name": "Get",
57144-
"printedName": "Get()",
57145-
"children": [
57146-
{
57147-
"kind": "TypeNominal",
57148-
"name": "Int32",
57149-
"printedName": "Swift.Int32",
57150-
"usr": "s:s5Int32V"
57151-
}
57152-
],
57153-
"declKind": "Accessor",
57154-
"usr": "s:SC33SENTRY_TARGET_PROFILING_SUPPORTEDs5Int32Vvg",
57155-
"mangledName": "$sSC33SENTRY_TARGET_PROFILING_SUPPORTEDs5Int32Vvg",
57156-
"moduleName": "Sentry",
57157-
"declAttributes": [
57158-
"Transparent"
57159-
],
57160-
"accessorKind": "get"
57161-
}
57162-
]
57163-
},
5716457112
{
5716557113
"kind": "Var",
5716657114
"name": "SENTRY_TARGET_REPLAY_SUPPORTED",

0 commit comments

Comments
 (0)