Skip to content

Commit 750199d

Browse files
ref: Remove SentrySDK from trace propagation class
1 parent 23935a2 commit 750199d

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

Sources/Sentry/SentryNetworkTracker.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ - (void)urlSessionTaskResume:(NSURLSessionTask *)sessionTask
191191
SentryBaggage *baggage = [[[SentryTracer getTracer:span] traceContext] toBaggage];
192192
[SentryTracePropagation addBaggageHeader:baggage
193193
traceHeader:[netSpan toTraceHeader]
194+
tracePropagationTargets:SentrySDKInternal.options.tracePropagationTargets
194195
toRequest:sessionTask];
195196

196197
SENTRY_LOG_DEBUG(
@@ -225,6 +226,7 @@ - (void)addTraceWithoutTransactionToTask:(NSURLSessionTask *)sessionTask
225226

226227
[SentryTracePropagation addBaggageHeader:[traceContext toBaggage]
227228
traceHeader:[propagationContext traceHeader]
229+
tracePropagationTargets:SentrySDKInternal.options.tracePropagationTargets
228230
toRequest:sessionTask];
229231
}
230232

Sources/Sentry/SentryTracePropagation.m

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
#import <SentryBaggage.h>
22
#import <SentryLogC.h>
3-
#import <SentrySDK+Private.h>
43
#import <SentrySwift.h>
54
#import <SentryTraceHeader.h>
65
#import <SentryTracePropagation.h>
76

87
@implementation SentryTracePropagation
98

109
+ (void)addBaggageHeader:(SentryBaggage *)baggage
11-
traceHeader:(SentryTraceHeader *)traceHeader
12-
toRequest:(NSURLSessionTask *)sessionTask
10+
traceHeader:(SentryTraceHeader *)traceHeader
11+
tracePropagationTargets:(NSArray *)tracePropagationTargets
12+
toRequest:(NSURLSessionTask *)sessionTask
1313
{
14-
if (![SentryTracePropagation sessionTaskRequiresPropagation:sessionTask]) {
14+
if (![SentryTracePropagation sessionTaskRequiresPropagation:sessionTask
15+
tracePropagationTargets:tracePropagationTargets]) {
1516
SENTRY_LOG_DEBUG(@"Not adding trace_id and baggage headers for %@",
1617
sessionTask.currentRequest.URL.absoluteString);
1718
return;
@@ -65,10 +66,11 @@ + (void)addBaggageHeader:(SentryBaggage *)baggage
6566
}
6667

6768
+ (BOOL)sessionTaskRequiresPropagation:(NSURLSessionTask *)sessionTask
69+
tracePropagationTargets:(NSArray *)tracePropagationTargets
6870
{
6971
return sessionTask.currentRequest != nil &&
7072
[SentryTracePropagation isTargetMatch:sessionTask.currentRequest.URL
71-
withTargets:SentrySDKInternal.options.tracePropagationTargets];
73+
withTargets:tracePropagationTargets];
7274
}
7375

7476
+ (BOOL)isTargetMatch:(NSURL *)URL withTargets:(NSArray *)targets

Sources/Sentry/include/SentryTracePropagation.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ NS_ASSUME_NONNULL_BEGIN
88
@interface SentryTracePropagation : NSObject
99

1010
+ (void)addBaggageHeader:(SentryBaggage *)baggage
11-
traceHeader:(SentryTraceHeader *)traceHeader
12-
toRequest:(NSURLSessionTask *)sessionTask;
11+
traceHeader:(SentryTraceHeader *)traceHeader
12+
tracePropagationTargets:(NSArray *)tracePropagationTargets
13+
toRequest:(NSURLSessionTask *)sessionTask;
1314

1415
+ (BOOL)isTargetMatch:(NSURL *)URL withTargets:(NSArray *)targets;
1516

0 commit comments

Comments
 (0)