-
-
Notifications
You must be signed in to change notification settings - Fork 372
feat: Add attributes data to SentryScope
#6830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itaybre
wants to merge
16
commits into
main
Choose a base branch
from
itay/scopes_set_attributes_logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8466253
feat: Add attributes data to `SentryScope`
itaybre 5be4764
Update changelog
itaybre 6566e2d
Update sdk_api.json
itaybre e1af624
Implement PR feedback
itaybre 8ab0b91
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/sc…
itaybre 0e8d3a3
Implement PR feedback
itaybre 27ab05d
Fix build in macOS before macOS 12
itaybre 7508b7f
Manually remove attachments from crashReporter's userInfo
itaybre 4fca042
Add `setAttributes` to `SentryScopeObserver`
itaybre a971271
Update note on `SentryScope`
itaybre 1d14b79
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/sc…
itaybre b05d464
Update changelog
itaybre 8430507
Add tests for SentryCrashIntegration
itaybre 1eac015
Add `setAttributes` to SentryCrashScopeObserver
itaybre 149dbca
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/sc…
itaybre 4dd8845
Update changelog
itaybre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
Samples/iOS-Swift/iOS-Swift/ViewControllers/ScopeViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import Sentry | ||
| import UIKit | ||
|
|
||
| class ScopeViewController: UIViewController { | ||
|
|
||
| @IBOutlet var attributesTextView: UITextView! | ||
| @IBOutlet var attributeNameField: UITextField! | ||
| @IBOutlet var attributeValueField: UITextField! | ||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| updateAttributesTextView() | ||
| } | ||
|
|
||
| @IBAction func setAttribute(_ sender: Any?) { | ||
| guard let attributeName = attributeNameField.text, let attributeValue = attributeValueField.text else { | ||
| return | ||
| } | ||
|
|
||
| SentrySDK.configureScope { scope in | ||
| scope.setAttribute(value: attributeValue, key: attributeName) | ||
| } | ||
|
|
||
| updateAttributesTextView() | ||
| } | ||
|
|
||
| @IBAction func removeAttribute(_ sender: Any?) { | ||
| guard let attributeName = attributeNameField.text else { | ||
| return | ||
| } | ||
|
|
||
| SentrySDK.configureScope { scope in | ||
| scope.removeAttribute(key: attributeName) | ||
| } | ||
|
|
||
| updateAttributesTextView() | ||
| } | ||
|
|
||
| @IBAction func updateAttributesTextView(_ sender: Any?) { | ||
| updateAttributesTextView() | ||
| } | ||
|
|
||
| private func updateAttributesTextView() { | ||
| SentrySDK.configureScope { [weak self] scope in | ||
| guard let self else { return } | ||
|
|
||
| guard let jsonData = try? JSONSerialization.data(withJSONObject: scope.attributes, options: [.prettyPrinted]) else { | ||
| self.attributesTextView.text = "Error serializing attributes to JSON" | ||
| return | ||
| } | ||
|
|
||
| guard let jsonString = String(data: jsonData, encoding: .utf8) else { | ||
| self.attributesTextView.text = "Error converting data to JSON text" | ||
| return | ||
| } | ||
|
|
||
| self.attributesTextView.text = jsonString | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.