Logs: Integrate in Sentry Client #2920
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/logs #2920 +/- ##
=============================================
+ Coverage 87.68% 87.74% +0.05%
=============================================
Files 275 277 +2
Lines 9089 9133 +44
=============================================
+ Hits 7970 8014 +44
Misses 1119 1119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denrase
changed the title
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
| } | ||
| if (processedLog != null) { | ||
| _options.logBatcher.addLog(processedLog); | ||
| } |
There was a problem hiding this comment.
should we report a dropped log if null after the beforeSendLog?
| void addLog(SentryLog log) { | ||
| _logBuffer.add(log); | ||
|
|
||
| _flushTimer?.cancel(); |
There was a problem hiding this comment.
canceling the timer here means that, in theory, if a log is added every 4 seconds, we will not flush them for several minutes
Is this the expectation?
Just fyi, Java sends every 5 seconds, regardless of how many logs are there
There was a problem hiding this comment.
i guess it's fine as per docs, just ensuring it's wanted
📜 Description
captureLogtoSentryClientenableLogstoSentryOptionsBeforeSendLogCallbacktoSentryOptions💡 Motivation and Context
Relates to #2915
Relates to #2919
Closes #2922
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Hub & New Loggers