fix(span): deprecation notice (#4336)

Author: bruno-garcia

src/Sentry/SentrySpan.cs

@@ -80,11 +80,11 @@ public void SetData(string key, object? value) =>
         (_data ??= new Dictionary<string, object?>())[key] = value;
 
     /// <inheritdoc />
-    [Obsolete("Use SetData")]
+    [Obsolete("Use Data")]
     public IReadOnlyDictionary<string, object?> Extra => Data;
 
     /// <inheritdoc />
-    [Obsolete("Use Data")]
+    [Obsolete("Use SetData")]
     public void SetExtra(string key, object? value) => SetData(key, value);
 
     /// <summary>

test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt

@@ -900,7 +900,7 @@ namespace Sentry
         public System.Collections.Generic.IReadOnlyDictionary<string, object?> Data { get; }
         public string? Description { get; set; }
         public System.DateTimeOffset? EndTimestamp { get; }
-        [System.Obsolete("Use SetData")]
+        [System.Obsolete("Use Data")]
         public System.Collections.Generic.IReadOnlyDictionary<string, object?> Extra { get; }
         public bool IsFinished { get; }
         public bool? IsSampled { get; }
@@ -915,7 +915,7 @@ namespace Sentry
         public Sentry.SentryId TraceId { get; }
         public Sentry.SentryTraceHeader GetTraceHeader() { }
         public void SetData(string key, object? value) { }
-        [System.Obsolete("Use Data")]
+        [System.Obsolete("Use SetData")]
         public void SetExtra(string key, object? value) { }
         public void SetMeasurement(string name, Sentry.Protocol.Measurement measurement) { }
         public void SetTag(string key, string value) { }

test/Sentry.Tests/ApiApprovalTests.Run.DotNet9_0.verified.txt

@@ -900,7 +900,7 @@ namespace Sentry
         public System.Collections.Generic.IReadOnlyDictionary<string, object?> Data { get; }
         public string? Description { get; set; }
         public System.DateTimeOffset? EndTimestamp { get; }
-        [System.Obsolete("Use SetData")]
+        [System.Obsolete("Use Data")]
         public System.Collections.Generic.IReadOnlyDictionary<string, object?> Extra { get; }
         public bool IsFinished { get; }
         public bool? IsSampled { get; }
@@ -915,7 +915,7 @@ namespace Sentry
         public Sentry.SentryId TraceId { get; }
         public Sentry.SentryTraceHeader GetTraceHeader() { }
         public void SetData(string key, object? value) { }
-        [System.Obsolete("Use Data")]
+        [System.Obsolete("Use SetData")]
         public void SetExtra(string key, object? value) { }
         public void SetMeasurement(string name, Sentry.Protocol.Measurement measurement) { }
         public void SetTag(string key, string value) { }

test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt

@@ -881,7 +881,7 @@ namespace Sentry
         public System.Collections.Generic.IReadOnlyDictionary<string, object?> Data { get; }
         public string? Description { get; set; }
         public System.DateTimeOffset? EndTimestamp { get; }
-        [System.Obsolete("Use SetData")]
+        [System.Obsolete("Use Data")]
         public System.Collections.Generic.IReadOnlyDictionary<string, object?> Extra { get; }
         public bool IsFinished { get; }
         public bool? IsSampled { get; }
@@ -896,7 +896,7 @@ namespace Sentry
         public Sentry.SentryId TraceId { get; }
         public Sentry.SentryTraceHeader GetTraceHeader() { }
         public void SetData(string key, object? value) { }
-        [System.Obsolete("Use Data")]
+        [System.Obsolete("Use SetData")]
         public void SetExtra(string key, object? value) { }
         public void SetMeasurement(string name, Sentry.Protocol.Measurement measurement) { }
         public void SetTag(string key, string value) { }