Merge branch 'timfish/build/exclude-debug-build-side-effects' of github.com:getsentry/sentry-javascript into timfish/build/exclude-debug-build-side-effects

Author: timfish

packages/svelte/src/debug_build.ts

@@ -0,0 +1,8 @@
+declare const __DEBUG_BUILD__: boolean;
+
+/**
+ * This serves as a build time flag that will be true by default, but false in non-debug builds or if users replace `__SENTRY_DEBUG__` in their generated code.
+ *
+ * ATTENTION: This constant must never cross package boundaries (i.e. be exported) to guarantee that it can be used for tree shaking.
+ */
+export const DEBUG_BUILD = __DEBUG_BUILD__;

packages/svelte/src/performance.ts

@@ -1,7 +1,8 @@
 import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/browser';
 import type { Span } from '@sentry/core';
-import { logger, startInactiveSpan } from '@sentry/core';
+import { debug, startInactiveSpan } from '@sentry/core';
 import { afterUpdate, beforeUpdate, onMount } from 'svelte';
+import { DEBUG_BUILD } from './debug_build';
 import type { TrackComponentOptions } from './types';
 
 const defaultTrackComponentOptions: {
@@ -37,9 +38,10 @@ export function trackComponent(options?: TrackComponentOptions): void {
     try {
       recordUpdateSpans(componentName);
     } catch {
-      logger.warn(
-        "Cannot track component updates. This is likely because you're using Svelte 5 in Runes mode. Set `trackUpdates: false` in `withSentryConfig` or `trackComponent` to disable this warning.",
-      );
+      DEBUG_BUILD &&
+        debug.warn(
+          "Cannot track component updates. This is likely because you're using Svelte 5 in Runes mode. Set `trackUpdates: false` in `withSentryConfig` or `trackComponent` to disable this warning.",
+        );
     }
   }
 }

packages/vue/src/tracing.ts

@@ -1,6 +1,6 @@
 import { getActiveSpan, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, startInactiveSpan } from '@sentry/browser';
 import type { Span } from '@sentry/core';
-import { logger, timestampInSeconds } from '@sentry/core';
+import { debug, timestampInSeconds } from '@sentry/core';
 import { DEFAULT_HOOKS } from './constants';
 import { DEBUG_BUILD } from './debug-build';
 import type { Hook, Operation, TracingOptions, ViewModel, Vue } from './types';
@@ -73,7 +73,7 @@ export const createTracingMixins = (options: Partial<TracingOptions> = {}): Mixi
     // eg. mount => ['beforeMount', 'mounted']
     const internalHooks = HOOKS[operation];
     if (!internalHooks) {
-      DEBUG_BUILD && logger.warn(`Unknown hook: ${operation}`);
+      DEBUG_BUILD && debug.warn(`Unknown hook: ${operation}`);
       continue;
     }
 

packages/vue/test/integration/VueIntegration.test.ts

@@ -3,7 +3,7 @@
  */
 
 import type { Client } from '@sentry/core';
-import { logger } from '@sentry/core';
+import { debug } from '@sentry/core';
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest';
 import { createApp } from 'vue';
 import * as Sentry from '../../src';
@@ -35,7 +35,7 @@ describe('Sentry.VueIntegration', () => {
     warnings = [];
     loggerWarnings = [];
 
-    vi.spyOn(logger, 'warn').mockImplementation((message: unknown) => {
+    vi.spyOn(debug, 'warn').mockImplementation((message: unknown) => {
       loggerWarnings.push(message);
     });