Add tests for onerror handling

Author: benvinegar

src/raven.js

@@ -155,10 +155,7 @@ Raven.prototype = {
         var self = this;
         if (this.isSetup() && !this._isRavenInstalled) {
             TraceKit.report.subscribe(function () {
-                // maintain 'self'
-                if (!self._ignoreOnError) {
-                    self._handleStackInfo.apply(self, arguments);
-                }
+                self._handleOnErrorStackInfo.apply(self, arguments);
             });
             this._wrapBuiltIns();
 
@@ -661,6 +658,13 @@ Raven.prototype = {
         return dsn;
     },
 
+    _handleOnErrorStackInfo: function(stackInfo, options) {
+        // if we are intentionally ignoring errors via onerror, bail out
+        if (!this._ignoreOnError) {
+            this._handleStackInfo.apply(this, arguments);
+        }
+    },
+
     _handleStackInfo: function(stackInfo, options) {
         var self = this;
         var frames = [];

test/integration/test.js

@@ -68,7 +68,26 @@ describe('integration', function () {
             );
         });
     });
-    describe('native', function () {
+
+    describe('window.onerror', function () {
+        it('should catch syntax errors', function (done) {
+            var iframe = this.iframe;
+
+            iframeExecute(iframe, done,
+                function () {
+                    setTimeout(done);
+                    eval('foo{};');
+                },
+                function () {
+                    var ravenData = iframe.contentWindow.ravenData;
+                    assert.isTrue(/SyntaxError/.test(ravenData.message)); // full message differs per-browser
+                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, 1); // just one frame
+                }
+            );
+        });
+    });
+
+    describe('wrapped built-ins', function () {
         it('should capture exceptions from event listeners', function (done) {
             var iframe = this.iframe;
 

test/raven.test.js

@@ -1264,6 +1264,36 @@ describe('globals', function() {
         });
     });
 
+    describe('handleOnErrorStackInfo', function () {
+        it('should call handleStackInfo if ignoreOnError is falsy', function () {
+            var frame = {url: 'http://example.com'};
+            this.sinon.stub(Raven, '_handleStackInfo');
+
+            var stackInfo = {
+                name: 'Matt',
+                message: 'hey',
+                url: 'http://example.com',
+                lineno: 10,
+                stack: [
+                    frame, frame
+                ]
+            };
+
+            Raven._ignoreOnError = 1;
+            Raven._handleOnErrorStackInfo(stackInfo, {foo: 'bar'});
+
+            assert.equal(Raven._handleStackInfo.callCount, 0);
+
+            Raven._ignoreOnError = 0;
+            Raven._handleOnErrorStackInfo(stackInfo, {foo: 'bar'});
+
+            assert.equal(Raven._handleStackInfo.callCount, 1);
+            assert.deepEqual(Raven._handleStackInfo.lastCall.args, [
+                stackInfo, {foo: 'bar'}
+            ]);
+        });
+    });
+
     describe('handleStackInfo', function() {
         it('should work as advertised', function() {
             var frame = {url: 'http://example.com'};