Commit 307d8ed
test(remix): Tighten or relax error filters that misidentified envelopes
- capture-exception / capture-message routes execute on both SSR and
client, so two error events were emitted; filter on
platform === 'javascript' so we assert against the browser one.
- The redirection-target loader and action-error tests asserted
event.transaction, but the SDK does not reliably set that field on
captured error events (integration tests never asserted it). Drop the
transaction filter and match on the mechanism + node platform instead.
- The throw-redirect server test filtered too narrowly on a specific
transaction name, risking a false-pass; widen to any node-side error.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 589b4c6 commit 307d8ed
2 files changed
Lines changed: 19 additions & 10 deletions
File tree
- dev-packages/e2e-tests/test-applications/create-remix-app-express/tests
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
34 | 39 | | |
35 | 40 | | |
36 | 41 | | |
| |||
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
54 | | - | |
| 59 | + | |
55 | 60 | | |
56 | 61 | | |
57 | 62 | | |
| |||
Lines changed: 12 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
60 | 63 | | |
61 | 64 | | |
| 65 | + | |
62 | 66 | | |
63 | | - | |
| 67 | + | |
64 | 68 | | |
65 | 69 | | |
66 | 70 | | |
| |||
77 | 81 | | |
78 | 82 | | |
79 | 83 | | |
| 84 | + | |
| 85 | + | |
80 | 86 | | |
81 | | - | |
| 87 | + | |
82 | 88 | | |
83 | 89 | | |
84 | 90 | | |
| |||
91 | 97 | | |
92 | 98 | | |
93 | 99 | | |
94 | | - | |
95 | 100 | | |
96 | | - | |
97 | 101 | | |
98 | 102 | | |
99 | 103 | | |
| |||
198 | 202 | | |
199 | 203 | | |
200 | 204 | | |
201 | | - | |
| 205 | + | |
202 | 206 | | |
203 | 207 | | |
204 | | - | |
205 | | - | |
| 208 | + | |
| 209 | + | |
206 | 210 | | |
207 | 211 | | |
208 | 212 | | |
| |||
212 | 216 | | |
213 | 217 | | |
214 | 218 | | |
215 | | - | |
| 219 | + | |
216 | 220 | | |
0 commit comments