File tree 5 files changed +6
-0
lines changed
replay-internal/src/coreHandlers/util
5 files changed +6
-0
lines changed Original file line number Diff line number Diff line change @@ -27,6 +27,7 @@ export function getDefaultIntegrations(options: CloudflareOptions): Integration[
27
27
functionToStringIntegration ( ) ,
28
28
linkedErrorsIntegration ( ) ,
29
29
fetchIntegration ( ) ,
30
+ // TODO(v10): the `include` object should be defined directly in the integration based on `sendDefaultPii`
30
31
requestDataIntegration ( sendDefaultPii ? undefined : { include : { cookies : false } } ) ,
31
32
consoleIntegration ( ) ,
32
33
] ;
Original file line number Diff line number Diff line change @@ -21,6 +21,7 @@ type RequestDataIntegrationOptions = {
21
21
include ?: RequestDataIncludeOptions ;
22
22
} ;
23
23
24
+ // TODO(v10): Change defaults based on `sendDefaultPii`
24
25
const DEFAULT_INCLUDE : RequestDataIncludeOptions = {
25
26
cookies : true ,
26
27
data : true ,
Original file line number Diff line number Diff line change @@ -61,6 +61,7 @@ const _nodeContextIntegration = ((options: ContextOptions = {}) => {
61
61
62
62
const updatedContext = _updateContext ( await cachedContext ) ;
63
63
64
+ // TODO(v10): conditional with `sendDefaultPii` here?
64
65
event . contexts = {
65
66
...event . contexts ,
66
67
app : { ...updatedContext . app , ...event . contexts ?. app } ,
Original file line number Diff line number Diff line change @@ -98,6 +98,8 @@ function _prepareXhrData(
98
98
} ;
99
99
}
100
100
101
+ // ---- This additional network data below is only captured for URLs defined in `networkDetailAllowUrls` ----
102
+
101
103
const xhrInfo = xhr [ SENTRY_XHR_DATA_KEY ] ;
102
104
const networkRequestHeaders = xhrInfo
103
105
? getAllowedHeaders ( xhrInfo . request_headers , options . networkRequestHeaders )
Original file line number Diff line number Diff line change @@ -59,6 +59,7 @@ export function getDefaultIntegrations(options: Options): Integration[] {
59
59
linkedErrorsIntegration ( ) ,
60
60
winterCGFetchIntegration ( ) ,
61
61
consoleIntegration ( ) ,
62
+ // TODO(v10): integration can be included - but integration should not add IP address etc
62
63
...( options . sendDefaultPii ? [ requestDataIntegration ( ) ] : [ ] ) ,
63
64
] ;
64
65
}
You can’t perform that action at this time.
0 commit comments