Skip to content

Commit 6015961

Browse files
HazATclaude
andcommitted
ci(lighthouse): drop concurrency block and dependency caching
Address review feedback from @mydea: this nightly cron does not need either concurrency control or a shared dependency cache. - The concurrency group keyed on `github.run_id` was a no-op (each run has a unique id, so nothing ever collided) and only obscured intent. - The `CACHED_DEPENDENCY_PATHS` env block existed solely to feed the `install-dependencies` composite action's cache step. Replacing that action with a plain `yarn install --frozen-lockfile --ignore-engines` removes the cache plumbing for what is at most a ~30s saving on a workflow that runs once per day. Co-Authored-By: claude-sonnet-4-5 <noreply@anthropic.com>
1 parent 86cfe88 commit 6015961

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

.github/workflows/lighthouse.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@ on:
88
- cron: '0 0 * * *'
99
workflow_dispatch:
1010

11-
concurrency:
12-
group: lighthouse-${{ github.run_id }}
13-
cancel-in-progress: false
14-
15-
env:
16-
CACHED_DEPENDENCY_PATHS: |
17-
${{ github.workspace }}/node_modules
18-
${{ github.workspace }}/packages/*/node_modules
19-
${{ github.workspace }}/dev-packages/*/node_modules
20-
2111
jobs:
2212
build-and-upload:
2313
name: Bundle and upload Lighthouse cells
@@ -35,7 +25,7 @@ jobs:
3525
- uses: actions/setup-node@v6
3626
with:
3727
node-version-file: 'package.json'
38-
- uses: ./.github/actions/install-dependencies
28+
- run: yarn install --frozen-lockfile --ignore-engines
3929
- run: yarn build:ci
4030
- run: yarn build:tarball
4131
- run: yarn test:prepare

0 commit comments

Comments
 (0)