commit all test fixes and lint

Author: c298lee

dev-packages/browser-integration-tests/suites/replay/customEvents/test.ts

@@ -8,9 +8,9 @@ import {
   expectedFIDPerformanceSpan,
   expectedFPPerformanceSpan,
   expectedLCPPerformanceSpan,
-  expectedTTFBPerformanceSpan,
   expectedMemoryPerformanceSpan,
   expectedNavigationPerformanceSpan,
+  expectedTTFBPerformanceSpan,
   getExpectedReplayEvent,
 } from '../../../utils/replayEventTemplates';
 import type { PerformanceSpan } from '../../../utils/replayHelpers';

dev-packages/browser-integration-tests/suites/replay/multiple-pages/test.ts

@@ -8,12 +8,12 @@ import {
   expectedFIDPerformanceSpan,
   expectedFPPerformanceSpan,
   expectedLCPPerformanceSpan,
-  expectedTTFBPerformanceSpan,
   expectedMemoryPerformanceSpan,
   expectedNavigationBreadcrumb,
   expectedNavigationPerformanceSpan,
   expectedNavigationPushPerformanceSpan,
   expectedReloadPerformanceSpan,
+  expectedTTFBPerformanceSpan,
   getExpectedReplayEvent,
 } from '../../../utils/replayEventTemplates';
 import {
@@ -81,7 +81,7 @@ sentryTest(
     const collectedPerformanceSpans = [...recording0.performanceSpans, ...recording1.performanceSpans];
     const collectedBreadcrumbs = [...recording0.breadcrumbs, ...recording1.breadcrumbs];
 
-    expect(collectedPerformanceSpans.length).toEqual(8);
+    expect(collectedPerformanceSpans.length).toEqual(9);
     expect(collectedPerformanceSpans).toEqual(
       expect.arrayContaining([
         expectedNavigationPerformanceSpan,
@@ -122,7 +122,7 @@ sentryTest(
     const collectedPerformanceSpansAfterReload = [...recording2.performanceSpans, ...recording3.performanceSpans];
     const collectedBreadcrumbsAdterReload = [...recording2.breadcrumbs, ...recording3.breadcrumbs];
 
-    expect(collectedPerformanceSpansAfterReload.length).toEqual(8);
+    expect(collectedPerformanceSpansAfterReload.length).toEqual(9);
     expect(collectedPerformanceSpansAfterReload).toEqual(
       expect.arrayContaining([
         expectedReloadPerformanceSpan,
@@ -316,7 +316,7 @@ sentryTest(
     ];
     const collectedBreadcrumbsAfterIndexNavigation = [...recording8.breadcrumbs, ...recording9.breadcrumbs];
 
-    expect(collectedPerformanceSpansAfterIndexNavigation.length).toEqual(8);
+    expect(collectedPerformanceSpansAfterIndexNavigation.length).toEqual(9);
     expect(collectedPerformanceSpansAfterIndexNavigation).toEqual(
       expect.arrayContaining([
         expectedNavigationPerformanceSpan,

dev-packages/e2e-tests/test-applications/react-send-to-sentry/tests/fixtures/ReplayRecordingData.ts

@@ -213,14 +213,14 @@ export const ReplayRecordingData = [
       tag: 'performanceSpan',
       payload: {
         op: 'web-vital',
-        description: 'largest-contentful-paint',
+        description: 'time-to-first-byte',
         startTimestamp: expect.any(Number),
         endTimestamp: expect.any(Number),
         data: {
           value: expect.any(Number),
           size: expect.any(Number),
           rating: expect.any(String),
-          nodeId: [16],
+          nodeId: [],
         },
       },
     },
@@ -232,14 +232,14 @@ export const ReplayRecordingData = [
       tag: 'performanceSpan',
       payload: {
         op: 'web-vital',
-        description: 'time-to-first-byte',
+        description: 'largest-contentful-paint',
         startTimestamp: expect.any(Number),
         endTimestamp: expect.any(Number),
         data: {
           value: expect.any(Number),
           size: expect.any(Number),
           rating: expect.any(String),
-          nodeId: [],
+          nodeId: [16],
         },
       },
     },

packages/replay-internal/src/util/createPerformanceEntries.ts

@@ -200,7 +200,6 @@ export function getCumulativeLayoutShift(metric: Metric): ReplayPerformanceEntry
       if (source.node) {
         nodes.push(source.node);
       }
-
     }
   }
   return getWebVital(metric, 'cumulative-layout-shift', nodes);