fix(remix): Keep the bundler plugin when source maps are disabled

`sourcemaps.disable: true` skipped the whole bundler plugin, which also
applies bundle size optimizations, module metadata, the application key
and release management. The plugin already declines the upload on its
own, so only the source map setting plugin needs gating.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: chargome

packages/remix/src/vite/index.ts

@@ -38,14 +38,22 @@ export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}
   const plugins: Plugin[] = [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
 
   // Uploading from the dev server would create a new set of artifacts on every restart.
-  if (process.env.NODE_ENV === 'development' || options.sourcemaps?.disable === true) {
+  if (process.env.NODE_ENV === 'development') {
     return plugins;
   }
 
+  // Added even when source maps are disabled: the bundler plugin also applies bundle size
+  // optimizations, module metadata, the application key and release management, and it already
+  // skips the upload itself.
+  //
   // Order matters: Vite passes the already-merged config to every `config` hook, so the deletion
-  // plugin has to read `build.sourcemap` before `makeEnableSourceMapsPlugin` sets it to 'hidden' -
-  // otherwise it treats the setting as user-owned and leaves the generated maps on disk.
-  plugins.push(...makeAddSentryVitePlugin(options), makeEnableSourceMapsPlugin(options));
+  // plugin has to read `build.sourcemap` before `makeEnableSourceMapsPlugin` sets it to 'hidden'.
+  plugins.push(...makeAddSentryVitePlugin(options));
+
+  // `'disable-upload'` still generates them - debug IDs are injected and the user uploads by hand.
+  if (options.sourcemaps?.disable !== true) {
+    plugins.push(makeEnableSourceMapsPlugin(options));
+  }
 
   return plugins;
 }

packages/remix/test/vite/index.test.ts

@@ -26,7 +26,11 @@ vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
   sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
 }));
 
-type CapturedSentryOptions = { sourcemaps?: { filesToDeleteAfterUpload?: Promise<unknown> } };
+type CapturedSentryOptions = {
+  applicationKey?: string;
+  bundleSizeOptimizations?: { excludeTracing?: boolean };
+  sourcemaps?: { filesToDeleteAfterUpload?: Promise<unknown> };
+};
 
 let capturedSentryOptions: CapturedSentryOptions | undefined;
 
@@ -112,10 +116,29 @@ describe('sentryRemixVitePlugin', () => {
     expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
   });
 
-  it('leaves out the source map plugins when source maps are disabled', () => {
+  // Disabling source maps must not drop the bundler plugin: it also applies bundle size
+  // optimizations, module metadata, the application key and release management, and it skips the
+  // upload on its own.
+  it('only drops the source map setting plugin when source maps are disabled', () => {
     const plugins = sentryRemixVitePlugin({ sourcemaps: { disable: true } });
 
-    expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
+    expect(plugins.map(plugin => plugin.name)).toEqual([
+      'sentry-remix-route-manifest',
+      'code-transformer',
+      'sentry-remix-files-to-delete-after-upload',
+      'sentry-vite-plugin',
+    ]);
+  });
+
+  it('forwards the non-source-map options when source maps are disabled', () => {
+    sentryRemixVitePlugin({
+      sourcemaps: { disable: true },
+      applicationKey: 'my-app-key',
+      bundleSizeOptimizations: { excludeTracing: true },
+    });
+
+    expect(capturedSentryOptions?.applicationKey).toBe('my-app-key');
+    expect(capturedSentryOptions?.bundleSizeOptimizations).toEqual({ excludeTracing: true });
   });
 
   it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {