fix: review comments

Author: isaacs

packages/cloudflare/src/baseSdk.ts

@@ -109,7 +109,7 @@ export function initWithDefaultIntegrations(
 
   // `false` or a custom list turns off the SDK defaults, late-loaded ones
   // included, unless an SDK built the list from the defaults.
-  const usesSdkDefaults = options.defaultIntegrations === undefined || !!options.extendsDefaultIntegrations;
+  const usesSdkDefaults = options.defaultIntegrations === undefined || !!options._extendsDefaultIntegrations;
   if (options.defaultIntegrations === undefined) {
     options.defaultIntegrations = getDefaultIntegrationsImpl(options);
   }

packages/cloudflare/src/client.ts

@@ -359,7 +359,7 @@ interface BaseCloudflareOptions {
    * the integrations of instrumented modules that load after `init()`.
    * @default false
    */
-  extendsDefaultIntegrations?: boolean;
+  _extendsDefaultIntegrations?: boolean;
 
   /**
    * The Cloudflare SDK is not OpenTelemetry native. By default (`false`) it does not set up a tracer

packages/cloudflare/test/sdk.test.ts

@@ -526,7 +526,7 @@ describe('getDefaultIntegrations', () => {
 
     test('adds it when a custom defaultIntegrations list extends the SDK defaults', async () => {
       resetSdk();
-      const client = init({ dsn: DSN, defaultIntegrations: [], extendsDefaultIntegrations: true });
+      const client = init({ dsn: DSN, defaultIntegrations: [], _extendsDefaultIntegrations: true });
 
       await loadMysqlLate(client);
 
@@ -538,7 +538,7 @@ describe('getDefaultIntegrations', () => {
       const client = init({
         dsn: DSN,
         defaultIntegrations: [],
-        extendsDefaultIntegrations: true,
+        _extendsDefaultIntegrations: true,
         integrations: defaults => defaults.filter(integration => integration.name !== 'Mysql'),
       });
 

packages/nuxt/src/runtime/plugins/sentry-cloudflare.server.ts

@@ -73,7 +73,7 @@ export const sentryCloudflareNitroPlugin =
             // Nitro's Cloudflare presets require the flag anyway, so opt into the full set.
             options: {
               defaultIntegrations: getDefaultIntegrations(cloudflareOptions),
-              extendsDefaultIntegrations: cloudflareOptions.defaultIntegrations === undefined,
+              _extendsDefaultIntegrations: cloudflareOptions.defaultIntegrations === undefined,
               ...cloudflareOptions,
             },
             request,

packages/nuxt/test/runtime/plugins/sentry-cloudflare.server.test.ts

@@ -36,7 +36,7 @@ describe('sentryCloudflareNitroPlugin', () => {
       expect.objectContaining({
         options: expect.objectContaining({
           defaultIntegrations: expect.any(Array),
-          extendsDefaultIntegrations: true,
+          _extendsDefaultIntegrations: true,
         }),
       }),
       expect.any(Function),
@@ -48,7 +48,7 @@ describe('sentryCloudflareNitroPlugin', () => {
 
     expect(wrapRequestHandler).toHaveBeenCalledWith(
       expect.objectContaining({
-        options: expect.objectContaining({ defaultIntegrations: [], extendsDefaultIntegrations: false }),
+        options: expect.objectContaining({ defaultIntegrations: [], _extendsDefaultIntegrations: false }),
       }),
       expect.any(Function),
     );

packages/sveltekit/src/worker/cloudflare.ts

@@ -23,7 +23,7 @@ export function initCloudflareSentryHandle(options: CloudflareOptions): Handle {
       rewriteFramesIntegration(),
       svelteKitSpansIntegration(),
     ],
-    extendsDefaultIntegrations: options.defaultIntegrations === undefined,
+    _extendsDefaultIntegrations: options.defaultIntegrations === undefined,
     // SvelteKit emits its own OpenTelemetry spans (Kit tracing), so, like the Node SvelteKit SDK, it
     // defaults to registering the tracer provider instead of inheriting Cloudflare's no-provider default.
     // Only the `init`-backed wrapper from the main entry point honors this; `@sentry/cloudflare/request`

packages/sveltekit/test/worker/cloudflare.test.ts

@@ -66,7 +66,7 @@ describe('initCloudflareSentryHandle', () => {
         options: expect.objectContaining({
           dsn: options.dsn,
           enableOpenTelemetrySetup: true,
-          extendsDefaultIntegrations: true,
+          _extendsDefaultIntegrations: true,
         }),
         request,
         context,
@@ -91,7 +91,7 @@ describe('initCloudflareSentryHandle', () => {
 
     expect(wrapRequestHandler).toHaveBeenCalledWith(
       expect.objectContaining({
-        options: expect.objectContaining({ defaultIntegrations: [], extendsDefaultIntegrations: false }),
+        options: expect.objectContaining({ defaultIntegrations: [], _extendsDefaultIntegrations: false }),
       }),
       expect.any(Function),
     );