Skip to content

Commit 8df2e90

Browse files
nicohrubecclaude
andcommitted
fix(e2e): Add node types to generic TS test tsconfigs
With types:[], @types/node was only loaded because @types/pg (transitive dep of instrumentation-pg) had `/// <reference types="node" />`. Removing instrumentation-pg broke that chain. Explicitly including "node" in types reflects what any real Node.js consumer would have. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c6acafc commit 8df2e90

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"lib": ["es2018", "DOM"],
55
"skipLibCheck": false,
66
"noEmit": true,
7-
"types": [],
7+
"types": ["node"],
88
"target": "es2018",
99
"moduleResolution": "node"
1010
}

dev-packages/e2e-tests/test-applications/generic-ts5.0/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"lib": ["es2018", "DOM"],
55
"skipLibCheck": false,
66
"noEmit": true,
7-
"types": [],
7+
"types": ["node"],
88
"target": "es2018",
99
"moduleResolution": "node"
1010
}

dev-packages/e2e-tests/test-applications/remix-hydrogen/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"forceConsistentCasingInFileNames": true,
1515
"skipLibCheck": true,
1616
"baseUrl": ".",
17-
"types": ["@shopify/oxygen-workers-types"],
17+
"types": ["@shopify/oxygen-workers-types", "node"],
1818
"paths": {
1919
"~/*": ["app/*"]
2020
},

0 commit comments

Comments
 (0)