Skip to content

Commit b82c941

Browse files
committed
fix tests for node 26
1 parent 5e9f2e7 commit b82c941

16 files changed

Lines changed: 78 additions & 0 deletions

File tree

dev-packages/node-core-integration-tests/suites/child-process/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type { Event } from '@sentry/core';
22
import { afterAll, describe, expect, test } from 'vitest';
33
import { conditionalTest } from '../../utils';
44
import { cleanupChildProcesses, createRunner } from '../../utils/runner';
5+
import { getNodeDeprecationBreadcrumbs } from '../../utils/node-deprecation-breadcrumbs';
56

67
const WORKER_EVENT: Event = {
78
exception: {
@@ -31,6 +32,7 @@ const CHILD_EVENT: Event = {
3132
],
3233
},
3334
breadcrumbs: [
35+
...getNodeDeprecationBreadcrumbs(),
3436
{
3537
category: 'child_process',
3638
message: "Child process exited with code '1'",

dev-packages/node-core-integration-tests/suites/tracing/requests/fetch-breadcrumbs/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { conditionalTest } from '../../../../utils';
44
import { createEsmAndCjsTests } from '../../../../utils/runner';
5+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
56

67
describe('outgoing fetch', () => {
78
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -14,6 +15,7 @@ describe('outgoing fetch', () => {
1415
.expect({
1516
event: {
1617
breadcrumbs: [
18+
...getNodeDeprecationBreadcrumbs(),
1719
{
1820
message: 'manual breadcrumb',
1921
timestamp: expect.any(Number),

dev-packages/node-core-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { createEsmAndCjsTests } from '../../../../utils/runner';
4+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
45

56
describe('outgoing fetch with tracePropagation disabled', () => {
67
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -23,6 +24,7 @@ describe('outgoing fetch with tracePropagation disabled', () => {
2324
.expect({
2425
event: {
2526
breadcrumbs: [
27+
...getNodeDeprecationBreadcrumbs(),
2628
{
2729
message: 'manual breadcrumb',
2830
timestamp: expect.any(Number),

dev-packages/node-core-integration-tests/suites/tracing/requests/http-breadcrumbs/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { createEsmAndCjsTests } from '../../../../utils/runner';
4+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
45

56
describe('outgoing http', () => {
67
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -12,6 +13,7 @@ describe('outgoing http', () => {
1213
.expect({
1314
event: {
1415
breadcrumbs: [
16+
...getNodeDeprecationBreadcrumbs(),
1517
{
1618
message: 'manual breadcrumb',
1719
timestamp: expect.any(Number),

dev-packages/node-core-integration-tests/suites/tracing/requests/http-no-trace-propagation/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { createEsmAndCjsTests } from '../../../../utils/runner';
4+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
45

56
describe('outgoing http with tracePropagation disabled', () => {
67
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -23,6 +24,7 @@ describe('outgoing http with tracePropagation disabled', () => {
2324
.expect({
2425
event: {
2526
breadcrumbs: [
27+
...getNodeDeprecationBreadcrumbs(),
2628
{
2729
message: 'manual breadcrumb',
2830
timestamp: expect.any(Number),

dev-packages/node-core-integration-tests/suites/tracing/requests/http-no-tracing-no-spans/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { createEsmAndCjsTests } from '../../../../utils/runner';
4+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
45

56
describe('outgoing http requests with tracing & spans disabled', () => {
67
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -41,6 +42,7 @@ describe('outgoing http requests with tracing & spans disabled', () => {
4142
],
4243
},
4344
breadcrumbs: [
45+
...getNodeDeprecationBreadcrumbs(),
4446
{
4547
message: 'manual breadcrumb',
4648
timestamp: expect.any(Number),

dev-packages/node-core-integration-tests/suites/tracing/requests/http-no-tracing/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { conditionalTest } from '../../../../utils';
44
import { createEsmAndCjsTests } from '../../../../utils/runner';
5+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
56

67
describe('outgoing http', () => {
78
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -43,6 +44,7 @@ describe('outgoing http', () => {
4344
],
4445
},
4546
breadcrumbs: [
47+
...getNodeDeprecationBreadcrumbs(),
4648
{
4749
message: 'manual breadcrumb',
4850
timestamp: expect.any(Number),
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
import type { Breadcrumb } from '@sentry/core';
2+
import { NODE_VERSION } from '@sentry/node-core';
3+
import { expect } from 'vitest';
4+
5+
export function getNodeDeprecationBreadcrumbs(): Breadcrumb[] {
6+
const message = `(node:4075) [DEP0205] DeprecationWarning: \`module.register()\` is deprecated. Use \`module.registerHooks()\` instead.
7+
(Use \`node --trace-deprecation ...\` to show where the warning was created)`;
8+
9+
if (NODE_VERSION.major < 26) {
10+
return [];
11+
}
12+
13+
return [
14+
{
15+
category: 'console',
16+
data: {
17+
arguments: [message],
18+
logger: 'console',
19+
},
20+
level: 'error',
21+
message: message,
22+
timestamp: expect.any(Number),
23+
},
24+
];
25+
}

dev-packages/node-integration-tests/suites/child-process/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type { Event } from '@sentry/core';
22
import { afterAll, describe, expect, test } from 'vitest';
33
import { conditionalTest } from '../../utils';
44
import { cleanupChildProcesses, createRunner } from '../../utils/runner';
5+
import { getNodeDeprecationBreadcrumbs } from '../../utils/node-deprecation-breadcrumbs';
56

67
const WORKER_EVENT: Event = {
78
exception: {
@@ -31,6 +32,7 @@ const CHILD_EVENT: Event = {
3132
],
3233
},
3334
breadcrumbs: [
35+
...getNodeDeprecationBreadcrumbs(),
3436
{
3537
category: 'child_process',
3638
message: "Child process exited with code '1'",

dev-packages/node-integration-tests/suites/tracing/requests/fetch-breadcrumbs/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { createTestServer } from '@sentry-internal/test-utils';
22
import { describe, expect } from 'vitest';
33
import { createEsmAndCjsTests } from '../../../../utils/runner';
4+
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';
45

56
describe('outgoing fetch', () => {
67
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
@@ -12,6 +13,7 @@ describe('outgoing fetch', () => {
1213
.expect({
1314
event: {
1415
breadcrumbs: [
16+
...getNodeDeprecationBreadcrumbs(),
1517
{
1618
message: 'manual breadcrumb',
1719
timestamp: expect.any(Number),

0 commit comments

Comments
 (0)