Skip to content

Commit e317b25

Browse files
committed
cleanup
1 parent 2732497 commit e317b25

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/vue/src/tracing.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const HOOKS: { [key in Operation]: Hook[] } = {
3131
update: ['beforeUpdate', 'updated'],
3232
};
3333

34-
/** Finish top-level component span and activity with a debounce configured using `timeout` option */
34+
/** End the top-level component span and activity with a debounce configured using `timeout` option */
3535
function maybeEndRootComponentSpan(vm: VueSentry, timestamp: number, timeout: number): void {
3636
if (vm.$_sentryRootComponentSpanTimer) {
3737
clearTimeout(vm.$_sentryRootComponentSpanTimer);
@@ -125,7 +125,7 @@ export const createTracingMixins = (options: Partial<TracingOptions> = {}): Mixi
125125
if (activeSpan) {
126126
// Cancel any existing span for this operation (safety measure)
127127
// We're actually not sure if it will ever be the case that cleanup hooks were not called.
128-
// However, we had users report that spans didn't get finished, so we finished the span before
128+
// However, we had users report that spans didn't end, so we end the span before
129129
// starting a new one, just to be sure.
130130
const oldSpan = this.$_sentryComponentSpans[operation];
131131
if (oldSpan) {
@@ -150,8 +150,8 @@ export const createTracingMixins = (options: Partial<TracingOptions> = {}): Mixi
150150
if (!span) return; // Skip if no span was created in the "before" hook
151151
span.end();
152152

153-
// For any "after" hook, also schedule the root component span to finish
154-
maybeEndRootComponentSpan(this, timestampInSeconds(), options.timeout || 2000);
153+
// For any "after" hook, also schedule the root component span to end
154+
maybeEndRootComponentSpan(this, timestampInSeconds(), rootComponentSpanFinalTimeout);
155155
}
156156
};
157157
}

0 commit comments

Comments
 (0)