feat(browser-utils): bump web-vitals to 5.1.0 #18091
Open
+133
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
force-pushed
the
awad/bump-web-vitals-to-5-1
branch
from
29c8b28 to
019cf99
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Remove the above event listener since no longer required. | ||
| // See: https://github.com/GoogleChrome/web-vitals/issues/622 | ||
| removePageListener('visibilitychange', cb, { capture: true }); | ||
| }); |
There was a problem hiding this comment.
Bug: Persistent Listeners Leak Memory.
The whenIdleOrHidden function creates a memory leak by calling onHidden(cb) which adds permanent visibilitychange and pagehide event listeners that are never removed. These listeners persist even after the callback has executed via runOnce, causing unnecessary memory consumption. This affects LCP measurement cleanup where stopListening is called via this function but the onHidden listeners remain active.
logaretm
force-pushed
the
awad/bump-web-vitals-to-5-1
branch
from
d9171bb to
dcbfc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the vendored-in web vitals library to include the changes between
5.0.2<->5.1.0from upstreamChanges from upstream
visibilitychangeevent listeners when no longer required #627Our own Changes
addPageListenerandremovePageListenerutilities because the upstream package changed the listeners to be added onwindowinstead ofdocument, so I added those utilities to avoid having to check for window every time we try to add a listener.